Op 20 mrt. 2012, om 14:51 heeft Paul Eggleton het volgende geschreven: > On Tuesday 20 March 2012 14:38:52 Koen Kooi wrote: >> Allow empty commits, this also give a nice speedup since 'git status >> --porcelain' doesn't need to get run. > > I guess my thinking before (without any verification) was that git commit > would > need to be running the equivalent of 'git status --porcelain' anyway and the > second time it would be cached so there wouldn't be much impact. If the > buildhistory repo is quite large or the machine is busy then it's entirely > possible that wouldn't work out however. > > Since all image builds will force a commit anyway (as at least build-id must > change), and for the majority of people most builds will be image builds, I > think this is going to be a net improvement. > > Therefore I'll say: > > Acked-by: Paul Eggleton <[email protected]>
After a few more days of usage I'm going to create a follow-up patch that will do: 1) reinstate the global git status --porcelain and make a single, empty commit if nothing changed instead of N empty commits. 2) either parse the output of git status or re-run it to see which top level entries need to get committed and only run 'git add ; git commit' on those. That will keep tracking all builds, but will be less noisy. But it will be slightly slower when the OS doesn't cache the git status, but I decided that I can personally live with that. So what do you think about that? If you like the idea, would you like it as follow up or as a respin of the series? regards, Koen _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
