Thanks Yoann,
I will resubmit these patches with your suggestions.

Le mer. 13 déc. 2023 à 15:47, Yoann Congal <[email protected]> a écrit :
>
> Hi Jonathan,
>
> Le 13/12/2023 à 15:15, Jonathan GUILLOT a écrit :
> > Just playing with cups and observe the main packages includes localized 
> > HTML templates in /usr/share/cups/templates. Locale packages were only 
> > looking for files in /usr/locale. This serie of patches allows to add extra 
> > directories to be scanned.
> > For a next patch, I would also like possible FILES:${PN}-locale-* variables 
> > defined in recipe not to be overriden by the split_locales() function.
> >
> > It is my first patch proposal on this project. Thanks in advance for your 
> > feedbacks.
>
> First, welcome! (If I'm not mistaken, we did work together some time ago :) )
>
> Rapidly glancing at your patches, I noticed they miss the "Signed-off-by:" 
> tag.
> Try to follow instructions at 
> https://docs.yoctoproject.org/dev/contributor-guide/submit-changes.html#implement-and-commit-changes.
> Basically, you'll need to rebase your commits and using "git commit --amend 
> -s".
>
> Another thing, the subject of your coverletter mail is "Hi," (you may want to 
> use a subject that provide some info on the content of your series)
>
> Regards,
>
> > Regards,
> > Jonathan GUILLOT
> >
> > Jonathan GUILLOT (3):
> >   lib/oe/package: replace in place PN-locale-* packages in PACKAGES
> >   lib/oe/package: add LOCALEEXTRADIRS to define extra locations for
> >     locales
> >   cups: use LOCALEEXTRADIRS to split localized HTML templates
> >
> >  meta/lib/oe/package.py              | 33 ++++++++++++++++++++++-------
> >  meta/recipes-extended/cups/cups.inc |  2 ++
> >  2 files changed, 27 insertions(+), 8 deletions(-)
> >
> >
> > base-commit: 564339afb73fc52a66c1a08437587cad1c4d46e7
> >
> >
> >
> > 
> >
>
> --
> Yoann Congal
> Smile ECS - Tech Expert
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#192298): 
https://lists.openembedded.org/g/openembedded-core/message/192298
Mute This Topic: https://lists.openembedded.org/mt/103149509/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to