On Sat, Dec 16, 2023 at 8:53 AM Etienne Cordonnier via lists.openembedded.org <[email protected]> wrote: > > From: Etienne Cordonnier <[email protected]> > > The function do_symlink_kernsrc is not reentrant in the case where S is > defined > to a non-default value. This causes build-failures e.g. when building > linux-yocto, then updating > poky to a commit which modifies kernel.bbclass, and then building linux-yocto > again. > > Bugzilla: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15325 > > Signed-off-by: Etienne Cordonnier <[email protected]> > --- > meta/classes-recipe/kernel.bbclass | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta/classes-recipe/kernel.bbclass > b/meta/classes-recipe/kernel.bbclass > index 9ff37f5c38..130bedd901 100644 > --- a/meta/classes-recipe/kernel.bbclass > +++ b/meta/classes-recipe/kernel.bbclass > @@ -194,6 +194,11 @@ python do_symlink_kernsrc () { > os.symlink(s, kernsrc) > else: > import shutil > + if os.path.islink(s): > + # this happens for instance when a poky update forces > symlink_kernsrc to run again > + # after s was already moved to kernsrc > + bb.warn("%s is already a symlink! Not symlinking kernel > sources" % s)
I don't think this is a warning situation, perhaps bb.info() is better. Since nothing is wrong, no unexpected results will occur and I really don't see any side effects .. is why I don't see it as a warning. Bruce > + return 0 > shutil.move(s, kernsrc) > os.symlink(kernsrc, s) > } > -- > 2.34.1 > > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#192590): https://lists.openembedded.org/g/openembedded-core/message/192590 Mute This Topic: https://lists.openembedded.org/mt/103208527/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
