There are a few additional remarks that I'd like some input on.
> + logger.error("No repository specified. Please provide one
> using '--repository REPOSITORY'.")
> + raise Exception("No repository specified. Please provide one
> using '--repository REPOSITORY'.")
I've included both an error message and an exception here, the exception is
what was used elsewhere already.
However, this doesn't provide clear feedback on what exactly is wrong, using an
error message will provide clear
feedback in my opinion. (It's a very obvious red message after all, and not
just a traceback that needs to be analysed.)
On the other hand, only using an error message isn’t quite sufficient either,
as it will not exit with an error code.
> + parser.add_argument('--repository', '-p',
I've named this option '--repository' as I would like to use '--update' with
'--repository', without '--reference'
at some point, in which case '--use-custom-reference' does not seem appropriate.
I'm open to suggestions and I'd like to know what people think about this.
Sincerely,
Jermain Horsman
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193411):
https://lists.openembedded.org/g/openembedded-core/message/193411
Mute This Topic: https://lists.openembedded.org/mt/103598114/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
