On Mon, 2024-01-08 at 17:14 +0000, Ross Burton wrote:
> On 3 Jan 2024, at 14:59, Richard Purdie via lists.openembedded.org
> <[email protected]> wrote:
> > --- a/meta/classes-recipe/gnomebase.bbclass
> > +++ b/meta/classes-recipe/gnomebase.bbclass
> > @@ -28,7 +28,7 @@ FILES:${PN} += "${datadir}/application-registry \
> > FILES:${PN}-doc += "${datadir}/devhelp"
> >
> > GNOMEBASEBUILDCLASS ??= "meson"
> > -inherit ${GNOMEBASEBUILDCLASS} pkgconfig
> > +inherit_defer ${GNOMEBASEBUILDCLASS} pkgconfig
>
> Feels like this should be split into inherit pkgconfig and inher_defer
> ${GNOMEBASEBUILDCLASS}.
I guess did it this way for ease in the patch, it won't really make
much difference either way, particularly for pkgconfig given how simple
that class is.
>
> > +inherit populate_sdk_base
> > +IMGCLASSES += "${@['', 'populate_sdk_ext']['linux' in d.getVar("SDK_OS")]}"
>
> Whilst you’re here change this to foo if bar else flob, this boolean
> subsetting idiom drives me insane.
I don't really mixing up changes as it just makes review harder so
whilst I don't mind changing that, I think it should be done
separately.
> > --- a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > +++ b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc
> > @@ -14,7 +14,7 @@ SRC_URI =
> > "${XORG_MIRROR}/individual/driver/${BPN}-${PV}${XORG_DRIVER_COMPRESSOR
> > FILES:${PN} += " ${libdir}/xorg/modules/drivers/*.so"
> >
> > XORGBUILDCLASS ??= "autotools"
> > -inherit ${XORGBUILDCLASS} pkgconfig features_check
> > +inherit_defer ${XORGBUILDCLASS} pkgconfig features_check
>
> As above.
>
> > -inherit autotools texinfo binconfig-disabled pkgconfig ${PYTHON_INHERIT}
> > python3native multilib_header
> > +inherit autotools texinfo binconfig-disabled pkgconfig multilib_header
> > +inherit_defer ${PYTHON_INHERIT} python3native
>
> Why is python3native defered?
In the past there were some ordering issues around the python classes
so I was just being careful not to cause more problems in the patchset
than I was already trying to debug. It probably isn't necessary but at
the time I wasn't 100% sure and there were bigger issues.
I can make the above tweaks if they really bother you...
Cheers,
Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193434):
https://lists.openembedded.org/g/openembedded-core/message/193434
Mute This Topic: https://lists.openembedded.org/mt/103502916/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
