On Tue, 9 Jan 2024 at 15:10, Richard Purdie <[email protected]> wrote: > The trouble is things can end up in the sysroot via indirect > dependencies so this change allows unintended changes to creep in (a > dependency adds jpeg so the config of webp could change too). I'm > therefore not happy about having "floating" dependencies this > introduces. > > Could we submit a patch upstream to avoid floating dependencies and > allow things to be specific?
I checked the source code. Checking the presence of gif/png/jpeg/tiff libraries is conditional on WEBP_FIND_IMG_LIBS being true, and that variable is set thusly: # Include dependencies. if(WEBP_BUILD_ANIM_UTILS OR WEBP_BUILD_CWEBP OR WEBP_BUILD_DWEBP OR WEBP_BUILD_EXTRAS OR WEBP_BUILD_GIF2WEBP OR WEBP_BUILD_IMG2WEBP) set(WEBP_FIND_IMG_LIBS TRUE) else() set(WEBP_FIND_IMG_LIBS FALSE) endif() So perhaps we can add PACKAGECONFIG for all six of these WEBP_BUILD things, and each would include the full set of image libraries as dependencies. The opengl dependency is needed only if WEBP_BUILD_VWEBP is set to true, so that would be another PACKAGECONFIG. This would avoid the need for new cmake options, but we would still need a patch to turn floating library dependencies into hard ones subject to the existing options listed above being enabled. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#193461): https://lists.openembedded.org/g/openembedded-core/message/193461 Mute This Topic: https://lists.openembedded.org/mt/103619059/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
