On Tue, 2024-01-09 at 15:56 +0800, Xiangyu Chen wrote:
> From: Xiangyu Chen <[email protected]>
> 
> Currently we are using external dependency generator, the rpm upstream already
> marked it as "Old Style Dependency Generators"[1], they also added a warning 
> message
> in rpm source code to inform that the external dependency generator is 
> deprecated[2].
> 
> Since it is only kept for backwards compatibility and may get removed in a 
> future
> release of rpm, so here is a proposal to use internal dependency generator by 
> default.
> 
> [1] 
> https://rpm-software-management.github.io/rpm/manual/dependency_generators.html
> [2] https://github.com/rpm-software-management/rpm/commit/cfcdd942
> 
> Signed-off-by: Xiangyu Chen <[email protected]>
> ---
>  meta/classes-global/package_rpm.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes-global/package_rpm.bbclass 
> b/meta/classes-global/package_rpm.bbclass
> index 2fc18fe98c..05cecee7d7 100644
> --- a/meta/classes-global/package_rpm.bbclass
> +++ b/meta/classes-global/package_rpm.bbclass
> @@ -681,7 +681,7 @@ python do_package_rpm () {
>      cmd = cmd + " --define '_topdir " + workdir + "' --define '_rpmdir " + 
> pkgwritedir + "'"
>      cmd = cmd + " --define '_builddir " + d.getVar('B') + "'"
>      cmd = cmd + " --define '_build_name_fmt 
> %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm'"
> -    cmd = cmd + " --define '_use_internal_dependency_generator 0'"
> +    cmd = cmd + " --define '_use_internal_dependency_generator 1'"
>      cmd = cmd + " --define '_binaries_in_noarch_packages_terminate_build 0'"
>      cmd = cmd + " --define '_build_id_links none'"
>      cmd = cmd + " --define '_source_payload %s'" % rpmbuild_compmode

This will not work since we have some significant use of the external
dependency generation elsewhere in the codebase. I'd also not that
message was from 2016, so probably not urgent at this point.

Cheers,

Richard
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193516): 
https://lists.openembedded.org/g/openembedded-core/message/193516
Mute This Topic: https://lists.openembedded.org/mt/103616137/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to