On Mon, Mar 26, 2012 at 11:46:48AM -0700, Darren Hart wrote: > What is the motivation?
RP's review comment. > On 03/23/2012 05:56 AM, Martin Jansa wrote: > > Signed-off-by: Martin Jansa <[email protected]> > > --- > > meta/classes/kernel.bbclass | 8 +++----- > > 1 files changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > > index 975ae13..54ed7f7 100644 > > --- a/meta/classes/kernel.bbclass > > +++ b/meta/classes/kernel.bbclass > > @@ -407,16 +407,14 @@ python populate_packages_prepend () { > > # appropriate modprobe commands to the postinst > > autoload = d.getVar('module_autoload_%s' % basename, True) > > if autoload: > > - name = '%s/etc/modutils/%s' % (dvar, basename) > > - f = open(name, 'w') > > - for m in autoload.split(): > > - f.write('%s\n' % m) > > - f.close() > > name = '%s/etc/modules-load.d/%s.conf' % (dvar, > > basename) > > f = open(name, 'w') > > for m in autoload.split(): > > f.write('%s\n' % m) > > f.close() > > + modutils_name = '%s/etc/modutils/%s' % (dvar, basename) > > + modutils_target = '../modules-load.d/%s.conf' % > > (basename) > > + os.symlink(modutils_target, modutils_name) > > This basically undoes what was added in 1/2 and replaces it with > symblinks right? > > If so, just do it as symlinks in the first place. I have't squashed them because [PATCH 1/6] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload was already applied to meta-oe's kernel.bbclass copy, before I got RP's review this patchset here, so I wanted to keep those patches 1to1. Cheers, -- Martin 'JaMa' Jansa jabber: [email protected]
signature.asc
Description: Digital signature
_______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
