On 06.03.24 17:42, [email protected] wrote:
> From: Christian Taedcke <[email protected]>
> 
> Without this commit the configuration node includes the compatible
> line 'compatible = [00];' if EXTERNAL_KERNEL_DEVICETREE is not
> defined, i.e. if PREFERRED_PROVIDER_virtual/dtb is not used.
> This prevents u-boot from using this configuration and it prints the
> message "Could not find configuration node".
> 
> An additional check also ensures that the written compatible line
> never contains an empty compatible.
> 
> The functionality to add the compatible line was added in commit
> f4c82fb6da89 ("kernel-fitImage: add machine compatible to config
> section").
> 
> Signed-off-by: Christian Taedcke <[email protected]>

Reviewed-by: Ahmad Fatoum <[email protected]>

Thanks,
Ahmad

> ---
>  meta/classes-recipe/kernel-fitimage.bbclass | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/kernel-fitimage.bbclass 
> b/meta/classes-recipe/kernel-fitimage.bbclass
> index 7e30a5d47e..4b74ddc201 100644
> --- a/meta/classes-recipe/kernel-fitimage.bbclass
> +++ b/meta/classes-recipe/kernel-fitimage.bbclass
> @@ -421,6 +421,7 @@ fitimage_emit_section_config() {
>       bootscr_line=""
>       setup_line=""
>       default_line=""
> +     compatible_line=""
>  
>       dtb_image_sect=$(symlink_points_below $dtb_image 
> "${EXTERNAL_KERNEL_DEVICETREE}")
>       if [ -z "$dtb_image_sect" ]; then
> @@ -428,7 +429,12 @@ fitimage_emit_section_config() {
>       fi
>  
>       dtb_path="${EXTERNAL_KERNEL_DEVICETREE}/${dtb_image_sect}"
> -     compatible_line="compatible = \"$(fdtget "$dtb_path" / compatible | sed 
> 's/ /", "/g')\";"
> +     if [ -e "$dtb_path" ]; then
> +             compat=$(fdtget -t s "$dtb_path" / compatible | sed 's/ /", 
> "/g')
> +             if [ -n "$compat" ]; then
> +                     compatible_line="compatible = \"$compat\";"
> +             fi
> +     fi
>  
>       dtb_image=$(echo $dtb_image | tr '/' '_')
>       dtb_image_sect=$(echo "${dtb_image_sect}" | tr '/' '_')

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196756): 
https://lists.openembedded.org/g/openembedded-core/message/196756
Mute This Topic: https://lists.openembedded.org/mt/104769468/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to