On Wed, Apr 17, 2024 at 12:56 PM John Ripple via lists.openembedded.org
<[email protected]> wrote:

> This patch adds a missing "%s" format in a logger.error call. Without
> this addition the logger itself would error out and not print a useful
> message.
>
> Signed-off-by: John Ripple <[email protected]>
> ---
>  scripts/lib/wic/plugins/source/rootfs.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/rootfs.py
> b/scripts/lib/wic/plugins/source/rootfs.py
> index e29f3a4c2f..c990143c0d 100644
> --- a/scripts/lib/wic/plugins/source/rootfs.py
> +++ b/scripts/lib/wic/plugins/source/rootfs.py
> @@ -43,7 +43,7 @@ class RootfsPlugin(SourcePlugin):
>          # directory, or modify a directory outside OpenEmbedded).
>          full_path = os.path.realpath(os.path.join(rootfs_dir, path))
>          if not full_path.startswith(os.path.realpath(rootfs_dir)):
> -            logger.error("%s: Must point inside the rootfs:" % (cmd,
> path))
> +            logger.error("%s: Must point inside the rootfs: %s" % (cmd,
> path))
>

Nice catch. Thank you.
Reviewed-by: Tim Orling <[email protected]>

             sys.exit(1)
>
>          return full_path
> --
> 2.34.1
>
> 
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#198553): 
https://lists.openembedded.org/g/openembedded-core/message/198553
Mute This Topic: https://lists.openembedded.org/mt/105585009/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to