Hi Florian,
On 7/2/24 10:14 AM, Florian Amstutz via lists.openembedded.org wrote:
You don't often get email from [email protected]. Learn
why this is important<https://aka.ms/LearnAboutSenderIdentification>
Since j is not unset after the inner loop, the image will only be copied
for the first configuration.
Signed-off-by: Florian Amstutz <[email protected]>
---
meta/classes/uboot-sign.bbclass | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/classes/uboot-sign.bbclass b/meta/classes/uboot-sign.bbclass
index 6bb4ddc600..5b75c8a3b0 100644
--- a/meta/classes/uboot-sign.bbclass
+++ b/meta/classes/uboot-sign.bbclass
@@ -137,8 +137,7 @@ concat_dtb_helper() {
if [ -n "${UBOOT_CONFIG}" ]
then
- i=0
- j=0
+ unset i j
What about only unsetting i and j wherever actually needed?
I.e.
unset i
here
for config in ${UBOOT_MACHINE}; do
i=$(expr $i + 1);
unset j
here
for type in ${UBOOT_CONFIG}; do
@@ -148,7 +147,9 @@ concat_dtb_helper() {
cp ${UBOOT_IMAGE}
${B}/${CONFIG_B_PATH}/u-boot-$type.${UBOOT_SUFFIX}
Breaking here would make a lot of (/more?) sense, we're otherwise
looping unnecessarily.
Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#201426):
https://lists.openembedded.org/g/openembedded-core/message/201426
Mute This Topic: https://lists.openembedded.org/mt/106996337/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
