On Wed, Jul 3, 2024 at 11:35 PM Jörg Sommer <[email protected]> wrote: > > Bruce Ashfield via lists.openembedded.org schrieb am Mi 03. Jul, 14:44 (GMT): > > On Wed, Jul 3, 2024 at 2:34 PM Jörg Sommer via lists.openembedded.org > > <[email protected]> wrote: > > > > > > Sadineni, Harish via lists.openembedded.org schrieb am Mi 03. Jul, 05:52 > > > (GMT): > > > > The following commit addressed the issue which checks whether the > > > > struct "task_struct" has __state or state > > > > https://github.com/chenhengqi/bcc/commit/d3cf5dcecfaeb6d8d346e2228626a7dbe506ad38 > > > > The above patch requires enabling CONFIG_DEBUG_INFO_BTF in the kernel > > > > and requires pahole. > > > > > > > diff --git a/meta/recipes-kernel/linux/linux-yocto.inc > > > > b/meta/recipes-kernel/linux/linux-yocto.inc > > > > index 0132fcffb3..d6b4794d32 100644 > > > > --- a/meta/recipes-kernel/linux/linux-yocto.inc > > > > +++ b/meta/recipes-kernel/linux/linux-yocto.inc > > > > @@ -65,11 +65,12 @@ KERNEL_DEBUG ?= "" > > > > DEPENDS += '${@bb.utils.contains_any("ARCH", [ "x86", "arm64", > > > > "powerpc" ], "elfutils-native", "", d)}' > > > > DEPENDS += "openssl-native util-linux-native" > > > > DEPENDS += "gmp-native libmpc-native" > > > > +DEPENDS += "pahole-native" > > > > > > > > # Some options depend on CONFIG_PAHOLE_VERSION, so need to make > > > > pahole-native available before do_kernel_configme > > > > do_kernel_configme[depends] += '${@bb.utils.contains("KERNEL_DEBUG", > > > > "True", "pahole-native:do_populate_sysroot", "", d)}' > > > > > > > > -EXTRA_OEMAKE += '${@bb.utils.contains("KERNEL_DEBUG", "True", "", > > > > "PAHOLE=false", d)}' > > > > +EXTRA_OEMAKE += '${@bb.utils.contains("KERNEL_DEBUG", "True", "", "", > > > > d)}' > > > > > > Can't this whole line be removed? > > > > Can you elaborate as to why it would be removed ? > > Maybe I interpret it wrong, but the true and the false case add nothing "" > to EXTRA_OEMAKE. Isn't the `+EXTRA_OEMAKE += … "", "", d` a NOP?
Oh, I see what you are saying! The patch as proposed isn't correct, so I was reading it from the point of view of the original line. I completely agree that "" in both cases would be removed completely :) Bruce -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201575): https://lists.openembedded.org/g/openembedded-core/message/201575 Mute This Topic: https://lists.openembedded.org/mt/107018570/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
