On 1 Jul 2024, at 17:33, Alexandre Belloni via lists.openembedded.org <[email protected]> wrote: > > On 01/07/2024 09:19:50-0700, Khem Raj wrote: >> On Mon, Jul 1, 2024 at 1:25 AM Yu, Mingli <[email protected]> wrote: >> >>> >>> >>> On 6/28/24 02:21, Khem Raj wrote: >>>> CAUTION: This email comes from a non Wind River email account! >>>> Do not click links or open attachments unless you recognize the sender >>> and know the content is safe. >>>> >>>> I am seeing two XPASSes which is ok but the test runs reports failure >>> back >>> >>> It is because the two cases defined as XFAIL_TESTS >>> https://git.savannah.nongnu.org/cgit/acl.git/tree/test/Makemodule.am#n1 >>> and per >>> >>> https://www.gnu.org/software/automake/manual/html_node/Generalities-about-Testing.html, >>> >>> >>> ``` >>> In case a test that is expected to fail ends up passing instead, many >>> testing environments will flag the result as a special kind of failure >>> called unexpected pass (or xpass). >>> ``` >> >> >> It’s fine here we need to treat them as passes so the return from tests do >> not confuse the preset runner > > But if we don't get the expected result, isn't that a failure?
I just spent a few minutes doing some git archaeology, but nothing useful. Both tests are marked as XFAIL which could mean “I wrote this test case but right now it doesn’t work correctly” or alternatively “this test is meant to fail”, but there’s nothing relevant in the comments or git log to clarify. The patches look like they’re fixing actual bugs in the test cases, so I suspect the tests were expected-fail because they didn’t actually work. So these patches should fix the tests and then move them from XFAIL_TESTS to TESTS as they now actually work. Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201633): https://lists.openembedded.org/g/openembedded-core/message/201633 Mute This Topic: https://lists.openembedded.org/mt/106904866/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
