Hello Richard, On 7/7/24 10:10, Richard Purdie wrote: > On Fri, 2024-07-05 at 16:46 +0200, Alexis Lothoré via lists.openembedded.org > wrote: >> From: Alexis Lothoré <[email protected]> >> + try: >> + cmd = f"tar zcf - {" ".join(artifacts_list)}" > > Thanks for the patch. The syntax above causes failures: > > https://valkyrie.yoctoproject.org/#/builders/95/builds/59/steps/14/logs/stdio > > I've put a fix on master-next which I can squash in but it does make me > wonder how it was tested.
Sorry about that. This error made me doubt about my testing setup, so I ran new tests, and I confirm that this line is being executed and returns a correct tar command on my machine, which confused me even more because it indeed looks broken. My best guess about those differences is a mismatch on python versions between the autobuilder and my machine. I am running python 3.12, and it appears that it has brought many improvements to python f-strings, especially "quote reuse", which makes python not raise an exception anymore when the expression inside an f-string reuses the same kind of quotes as for the parent f-string (see [1]). I ran a quick test with Python 3.11 instead of 3.12, and I now I see the exception. I guess it would be better for me to keep working with the same python version as in the autobuilder. I see mentions of python 3.6 in README-WALKTHROUGHS.md from the autobuilder2 repository, but I am not sure how up-to-date it is. Could you please confirm whether this is the correct version or not? Thanks, Alexis [1] https://docs.python.org/3/whatsnew/3.12.html#pep-701-syntactic-formalization-of-f-strings -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201638): https://lists.openembedded.org/g/openembedded-core/message/201638 Mute This Topic: https://lists.openembedded.org/mt/107054834/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
