But does this fix any actual issue? It’s not enough to justify the change with a ‘linter is complaining’. Reading the link, it’s about supporting a hypothetical weak assignment to SRC_URI, which basically never happens in real recipes.
Alex On Wed 10. Jul 2024 at 21.47, jermigra via lists.openembedded.org <[email protected]> wrote: > The oelint-adv linter checks fails when linting the recipe generated when > inheriting cargo-update-recipe-crates class. > It fails with the the oelint.bars.srcuriappend error. See > https://github.com/priv-kweihmann/oelint-adv/blob/master/docs/wiki/oelint.vars.srcuriappend.md#oelintvarssrcuriappend > Fixed by using override style append instead of the += syntax. > > Signed-off-by: jermigra <[email protected]> > --- > meta/classes-recipe/cargo-update-recipe-crates.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes-recipe/cargo-update-recipe-crates.bbclass > b/meta/classes-recipe/cargo-update-recipe-crates.bbclass > index a19ce16b46..88a5b0e4dd 100644 > --- a/meta/classes-recipe/cargo-update-recipe-crates.bbclass > +++ b/meta/classes-recipe/cargo-update-recipe-crates.bbclass > @@ -31,7 +31,7 @@ do_update_crates() { > def get_crates(f): > import tomllib > c_list = '# from %s' % os.path.relpath(f, '${CARGO_LOCK_SRC_DIR}') > - c_list += '\nSRC_URI += " \\\' > + c_list += '\nSRC_URI:append = " \\\' > crates = tomllib.load(open(f, 'rb')) > > # Build a list with crates info that have crates.io in the source > -- > 2.25.1 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#201742): https://lists.openembedded.org/g/openembedded-core/message/201742 Mute This Topic: https://lists.openembedded.org/mt/107149938/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
