On Wed, 24 Jul 2024 at 19:10, Tom Hochstein via lists.openembedded.org <[email protected]> wrote: > -GLIBC_64BIT_TIME_FLAGS = " -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" > +TARGET_CC_ARCH += "${GLIBC_64BIT_TIME_FLAGS}" > > # Only needed for some 32-bit architectures, some relatively newer > # architectures do not need it ( e.g. riscv32 ) > -TARGET_CC_ARCH:append:arm = "${GLIBC_64BIT_TIME_FLAGS}" > -TARGET_CC_ARCH:append:armeb = "${GLIBC_64BIT_TIME_FLAGS}" > -TARGET_CC_ARCH:append:mipsarcho32 = "${GLIBC_64BIT_TIME_FLAGS}" > -TARGET_CC_ARCH:append:powerpc = "${@bb.utils.contains('TUNE_FEATURES', > 'm32', '${GLIBC_64BIT_TIME_FLAGS}', '', d)}" > -TARGET_CC_ARCH:append:x86 = "${@bb.utils.contains('TUNE_FEATURES', 'm32', > '${GLIBC_64BIT_TIME_FLAGS}', '', d)}" > +GLIBC_64BIT_TIME_FLAGS = "" > +GLIBC_64BIT_TIME_FLAGS:arm = "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" > +GLIBC_64BIT_TIME_FLAGS:armeb = "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" > +GLIBC_64BIT_TIME_FLAGS:mipsarcho32 = "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" > +GLIBC_64BIT_TIME_FLAGS:powerpc = \ > + "${@bb.utils.contains('TUNE_FEATURES', 'm32', '-D_TIME_BITS=64 > -D_FILE_OFFSET_BITS=64', '', d)}" > +GLIBC_64BIT_TIME_FLAGS:x86 = \ > + "${@bb.utils.contains('TUNE_FEATURES', 'm32', '-D_TIME_BITS=64 > -D_FILE_OFFSET_BITS=64', '', d)}"
Apologies, but this is not simpler or better or more readable. Repeating "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" multiple times should really be avoided. What prompted this patch specifically? Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#202474): https://lists.openembedded.org/g/openembedded-core/message/202474 Mute This Topic: https://lists.openembedded.org/mt/107527348/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
