On 02/08/2024 13:51:45+0100, Richard Purdie wrote: > On Fri, 2024-08-02 at 12:36 +0000, Ross Burton via > lists.openembedded.org wrote: > > On 1 Aug 2024, at 09:22, Martin Hundeb?ll via lists.openembedded.org > > <[email protected]> wrote: > > > diff --git a/meta/recipes-core/ell/ell_0.67.bb b/meta/recipes- > > > core/ell/ell_0.67.bb > > > index 6b0ebbe62113..ee9aa73d2908 100644 > > > --- a/meta/recipes-core/ell/ell_0.67.bb > > > +++ b/meta/recipes-core/ell/ell_0.67.bb > > > @@ -10,9 +10,27 @@ SECTION = "libs" > > > LICENSE = "LGPL-2.1-only" > > > LIC_FILES_CHKSUM = > > > "file://COPYING;md5=fb504b67c50331fc78734fed90fb0e09" > > > > > > -DEPENDS = "dbus" > > > +DEPENDS = "dbus openssl-native xxd-native" > > > > This should be conditional on ptest, right? > > > > > +EXTRA_OECONF += "--enable-tests --enable-maintainer-mode" > > > > Make this conditional on ptest too? > > > > > +do_compile:prepend() { > > > + mkdir -p ${B}/unit > > > +} > > > > This sounds like a broken Makefile.am that has a bad assumption in. > > > > > +do_install_ptest() { > > > + install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit - > > > executable -type f) > > > + install -Dt ${D}${PTEST_PATH}/unit \ > > > + ${S}/unit/dbus.conf \ > > > + ${S}/unit/settings.test \ > > > + $(find ${B}/unit -name \*.pem -type f) > > > +} > > > > As the test scripts are built with libtool, it’s best to use libtool > > —mode=install to install them. > > Thanks for the review Ross. There was also a failure in automated > testing on the autobuilder: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/81/builds/6864/steps/12/logs/stdio > > The arm tests haven't run yet in that build.
It failed to build on arm64: https://autobuilder.yoctoproject.org/typhoon/#/builders/82/builds/6689/steps/11/logs/stdio > > Cheers, > > Richard > > > > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#202937): https://lists.openembedded.org/g/openembedded-core/message/202937 Mute This Topic: https://lists.openembedded.org/mt/107661617/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
