Without the fix you can check that with:
Set on local.conf : INHERIT += "buildhistory"
Run: bitbake -c cleansstate base-passwd && bitbake base-passwd

Taking a look on buildhistory you will see that for base-passwd packages there 
is no files-in-package.txt

Reason:
On log.do_package, theres a log,"DEBUG: Shell function 
buildhistory_list_pkg_files finished", which indicates that the main shell 
function for the `files-in-package.txt` was triggered an so the function 
expects that the recipe package folder exists it will skip 
`files-in-package.txt` creation.

On `packageData` task, there a python function `write_pkghistory` that runs for 
all packages from a recipe package and this function is protected to create the 
folder if this doesn’t exists.
When writing `latest` we are protecting it from failing to write down the file 
but for `files-in-package.txt` we don’t.

My best regards,

Pedro Ferreira

-----Original Message-----
From: Richard Purdie <[email protected]>
Sent: Friday, August 2, 2024 3:33 PM
To: Pedro Silva Ferreira <[email protected]>; 
[email protected]
Cc: Pedro Ferreira <[email protected]>
Subject: Re: [OE-core] [PATCH 1/2] buildhistory: fix package output folder 
creation

Notice: This e-mail has originated from an external email service, so do not 
click on any links, nor open any attachments unless you know who the sender is 
and are sure the content is secure.



On Fri, 2024-08-02 at 15:00 +0100, Pedro Ferreira via lists.openembedded.org 
wrote:
> This fix garantees that output package folder exists on buildhistory
> folder to avoid missing files-in-package.txt creation during task
> `package` execution.
>
> This issue happens because the output folder is being created on task
> `packagedata` before generating `latest` file.
>
> Also it ensures that in case of `find` fails we leave with a hard
> error instead of hidding the error on the for loop.
>
> Signed-off-by: Pedro Ferreira <[email protected]>
> ---
>  meta/classes/buildhistory.bbclass | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)

How would someone reproduce the bug being fixed here?

I'm a little worried that this might really be a build race or a dependency 
problem. If that is the case, creating the directory doesn't seem the right 
thing to do and is just working around the problem?

Cheers,

Richard
The information in this communication may contain confidential or legally 
privileged information. It is intended solely for the use of the individual or 
entity it addresses and others authorized to receive it. If you are not an 
intended recipient, you are hereby notified that any disclosure, copying, 
distribution or action in reliance on the contents of this information is 
strictly prohibited and may be unlawful. If you have received this 
communication by error, please notify us immediately by responding to this 
e-mail and then delete it from your system. Critical TechWorks is not liable 
for the proper and complete transmission of the information in this 
communication nor for any delay in its receipt

This e-mail is environmentally friendly, just like Critical TechWorks, which 
lives in a paper-free atmosphere. Therefore, please consider the environment 
before printing it!
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#202993): 
https://lists.openembedded.org/g/openembedded-core/message/202993
Mute This Topic: https://lists.openembedded.org/mt/107685168/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to