Am Donnerstag, dem 08.08.2024 um 12:16 +0000 schrieb Peter Kjellerstedt:
> > -----Original Message-----
> > From: [email protected]
> > <[email protected]> On
> > Behalf Of Enrico Jörns
> > Sent: den 8 augusti 2024 13:04
> > To: [email protected]
> > Cc: [email protected]
> > Subject: [OE-core] [PATCH] archiver.bbclass: fix
> > BB_GENERATE_MIRROR_TARBALLS checking
> >
> > The variable 'have_mirror_tarballs' is used as a boolean while it is
> > actually the result of 'd.getVar('BB_GENERATE_MIRROR_TARBALLS')' and
> > thus a string.
> >
> > Fix this by converting it into a boolean before using it.
> >
> > Signed-off-by: Enrico Jörns <[email protected]>
> > ---
> > meta/classes/archiver.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/archiver.bbclass b/meta/classes/archiver.bbclass
> > index 9d286224d6..9c8b0daf31 100644
> > --- a/meta/classes/archiver.bbclass
> > +++ b/meta/classes/archiver.bbclass
> > @@ -339,7 +339,7 @@ python do_ar_mirror() {
> > dl_dir = d.getVar('DL_DIR')
> > mirror_exclusions = (d.getVar('ARCHIVER_MIRROR_EXCLUDE') or '').split()
> > mirror_mode = d.getVarFlag('ARCHIVER_MODE', 'mirror')
> > - have_mirror_tarballs = d.getVar('BB_GENERATE_MIRROR_TARBALLS')
> > + have_mirror_tarballs = d.getVar('BB_GENERATE_MIRROR_TARBALLS') == "1"
>
> May I suggest:
>
> have_mirror_tarballs =
> oe.types.boolean(d.getVar('BB_GENERATE_MIRROR_TARBALLS'))
>
> instead?
Oh, did not know this helper exists. Thank you for the hint!
Will send a v2.
Regards, Enrico
> >
> > if mirror_mode == 'combined':
> > destdir = d.getVar('ARCHIVER_COMBINED_MIRRORDIR')
> > --
> > 2.39.2
>
> //Peter
>
--
Pengutronix e.K. | Enrico Jörns |
Embedded Linux Consulting & Support | https://www.pengutronix.de/ |
Steuerwalder Str. 21 | Phone: +49-5121-206917-180 |
31137 Hildesheim, Germany | Fax: +49-5121-206917-9 |
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203159):
https://lists.openembedded.org/g/openembedded-core/message/203159
Mute This Topic: https://lists.openembedded.org/mt/107787362/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
