On Thu, 2024-08-08 at 03:00 -0700, Yash Shinde via lists.openembedded.org wrote: > From: Yash Shinde <[email protected]> > > Add the failing tests in rust v1.76 to the exclude list > and add "ignore" tags to ignore failing unit test cases. > > Signed-off-by: Yash Shinde <[email protected]> > --- > meta/lib/oeqa/selftest/cases/rust.py | 19 + > .../rust/files/rust-oe-selftest.patch | 345 ++++++++++++++++++ > meta/recipes-devtools/rust/rust-source.inc | 1 + > 3 files changed, 365 insertions(+) > create mode 100644 meta/recipes-devtools/rust/files/rust-oe-selftest.patch > > diff --git a/meta/lib/oeqa/selftest/cases/rust.py > b/meta/lib/oeqa/selftest/cases/rust.py > index 4ccbe9867b..6181c10ea9 100644 > --- a/meta/lib/oeqa/selftest/cases/rust.py > +++ b/meta/lib/oeqa/selftest/cases/rust.py > @@ -187,6 +187,25 @@ class RustSelfTestSystemEmulated(OESelftestTestCase, > OEPTestResultTestCase): > 'tests/rustdoc-ui/no-run-flag.rs', > 'tests/ui-fulldeps/', > 'tests/ui/numbers-arithmetic/u128.rs' > + 'tests/run-pass-valgrind', > + 'tests/ui/codegen/mismatched-data-layouts.rs', > + 'tests/codegen/i128-x86-align.rs', > + 'src/tools/suggest-tests', > + 'src/tools/rust-installer', > + 'src/bootstrap', > + 'src/tools/tidy/src/', > + 'library/std/src/thread/tests.rs', > + > 'compiler/rustc_errors/src/markdown/tests/term.rs', > + 'compiler/rustc_interface/src/tests.rs', > + 'library/std/src/io/buffered/tests.rs', > + 'library/std/src/io/stdio/tests.rs', > + 'library/std/src/sync/mpsc/sync_tests.rs', > + 'library/std/src/sync/mpsc/tests.rs', > + 'library/std/src/sync/mutex/tests.rs', > + 'library/std/src/sync/rwlock/tests.rs', > + 'library/std/src/thread/tests.rs', > + 'library/test/src/stats/tests.rs', > + 'tidyselftest' > ] > > exclude_fail_tests = " ".join([" --exclude " + item for item in > exclude_list]) > diff --git a/meta/recipes-devtools/rust/files/rust-oe-selftest.patch > b/meta/recipes-devtools/rust/files/rust-oe-selftest.patch > new file mode 100644 > index 0000000000..0280b1ef8c > --- /dev/null > +++ b/meta/recipes-devtools/rust/files/rust-oe-selftest.patch > @@ -0,0 +1,345 @@ > +Backport the patch for "ensure std for cross-targets". > + > +Previously, doing `x test compiler/*` would fail the build due to missing > std. > +This change ensures that it is prepared. > + > +Also, add "[ignore]" tags to the failing unit tests to > +ignore them during rust oe-selftest. > + > +Upstream-Status: Backport > [https://github.com/rust-lang/rust/pull/122205/commits/5aece7fad06baaa745784d118db862b3e3ccf7f8] > + > +Signed-off-by: Yash Shinde <[email protected]>
When adding changes in a patch like this, please separate "backports" from the pieces which aren't backports. These should be two separate patches, so when we upgrade, the ignore part of the patch can be more easily retained (if still needed) and we can simply drop the backport piece. I've tweaked the patch in the merge queue to do this on this occasion. I've had to make the same change to a later 1.77 patch too. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#203161): https://lists.openembedded.org/g/openembedded-core/message/203161 Mute This Topic: https://lists.openembedded.org/mt/107786804/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
