Thanks. All of this information should be in the patch, can you add and resend please?
Alex On Tue, 13 Aug 2024 at 18:27, Trevor Gamblin <[email protected]> wrote: > > > On 2024-08-13 11:47 a.m., Alexander Kanavin wrote: > > On Tue, 13 Aug 2024 at 17:30, Trevor Gamblin via > > lists.openembedded.org <[email protected]> > > wrote: > >> Python 3.12.5 is failing a newer ptest for reading/writing limited > >> history. Skip it for now until a proper fix (if any) is determined. > >> +This test was added recently and is failing on the ptest image. Disable > >> +it until the proper fix is determined. > > We should not be disabling tests without any investigation at all into > > why they fail, just so some other functionality (e.g. version updates) > > can merge into master. I have to say no to this. Please look into it. > > > > If it was added recently, what was the commit that added it? Can you > > add a link to that commit? > > It was added in > https://github.com/python/cpython/commit/263c7e611bb24715e513d457a3477a61fff15162 > > The GitHub issue is here: https://github.com/python/cpython/issues/121160 > > > > > If it fails, what happens exactly? Where is the failure coming from? > > Does the test expect something on the target image that isn't being > > provided? > > > > etc. > > The failure looks like: > > FAIL: test_write_read_limited_history > (test.test_readline.TestReadline.test_write_read_limited_history) > > ====================================================================== > ERROR: test_write_read_limited_history > (test.test_readline.TestHistoryManipulation.test_write_read_limited_history) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/usr/lib/python3.12/test/test_readline.py", line 153, in > test_write_read_limited_history > readline.read_history_file(TESTFN) > OSError: [Errno 22] Invalid argument > > ====================================================================== > ERROR: test_write_read_limited_history > (test.test_readline.TestReadline.test_write_read_limited_history) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/usr/lib/python3.12/test/test_readline.py", line 362, in > test_write_read_limited_history > readline.read_history_file(TESTFN) > OSError: [Errno 22] Invalid argument > > ---------------------------------------------------------------------- > Ran 11 tests in 0.266s > > FAILED (errors=2, skipped=3) > test test_readline failed > > It's not clear to me what the fix is, seems like maybe an issue with the > readline available in python3 ptest images. I've looked at TESTFN and > the HISTORY_FILE environment variable that the test is supposedly using. > The aforementioned bug report suggests that OSErrors like that show up > when using the GNU readline-based readline module if a workaround isn't > also incorporated. It also mentions a new readline backend will be > available in 3.13 that might help, but that won't be available for a year. > > > > > Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#203287): https://lists.openembedded.org/g/openembedded-core/message/203287 Mute This Topic: https://lists.openembedded.org/mt/107878153/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
