> -----Original Message-----
> From: [email protected] 
> <[email protected]> On Behalf Of Niko Mauno via 
> lists.openembedded.org
> Sent: den 19 augusti 2024 12:10
> To: [email protected]
> Cc: Niko Mauno <[email protected]>
> Subject: [OE-core] [PATCH v4] util-linux: Add PACKAGECONFIG option to 
> mitigate rootfs remount error
> 

[cut]

> ---
>  meta/recipes-core/util-linux/util-linux_2.40.1.bb | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/meta/recipes-core/util-linux/util-linux_2.40.1.bb 
> b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> index a1aab94055..0b36df8e1b 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.40.1.bb
> @@ -107,6 +107,13 @@ PACKAGECONFIG[cryptsetup] = 
> "--with-cryptsetup,--without-cryptsetup,cryptsetup"
>  PACKAGECONFIG[chfn-chsh] = "--enable-chfn-chsh,--disable-chfn-chsh,"
>  PACKAGECONFIG[selinux] = "--with-selinux,--without-selinux,libselinux"
>  PACKAGECONFIG[lastlog2] = 
> "--enable-liblastlog2,--disable-liblastlog2,sqlite3"
> +# Using the new file descriptors based mount kernel API can cause rootfs 
> remount failure with some older kernels.
> +# Of currently supported LTS kernels, the old mount API should be used with:
> +# - versions prior to 6.6.18 in the 6.6.y series.
> +# - versions prior to 6.1.79 in the 6.1.y series.
> +# - versions till at least 5.15.164 in the 5.15.y series.
> +# - with 5.10.y, 5.4.y and 4.19.y series kernels, libmount seemed to use the 
> old API regardless of this option.
> +PACKAGECONFIG[no-new-mount-api] = 
> "--disable-libmount-mountfd-support,--enable-libmount-mountfd-support"

Please avoid negative PACKAGECONFIGs. Instead use:

PACKAGECONFIG[new-mount-api] = 
"--enable-libmount-mountfd-support,--disable-libmount-mountfd-support"

and add "new-mount-api" to the default for PACKAGECONFIG.

Also, how long will the "new" in "new-mount-api" be valid, i.e., what 
happens when the next mount API comes along? It might be better to match 
the feature name to the configuration option, e.g.:

PACKAGECONFIG[libmount-mountfd-support] = 
"--enable-libmount-mountfd-support,--disable-libmount-mountfd-support"

> 
>  EXTRA_OEMAKE = "ARCH=${TARGET_ARCH} CPU= CPUOPT= 'OPT=${CFLAGS}'"
> 
> --
> 2.39.2

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203515): 
https://lists.openembedded.org/g/openembedded-core/message/203515
Mute This Topic: https://lists.openembedded.org/mt/107977721/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to