On Wed, Aug 21, 2024 at 10:58 AM Richard Purdie <
[email protected]> wrote:

> On Wed, 2024-08-21 at 07:17 +0200, Marta Rybczynska via
> lists.openembedded.org wrote:
> > The cve-check JSON format has been present for a long time now,
> > and this is a moment to disable the TEXT output.
> >
> > The JSON format is easier to parse by automatic tools, so users
> > should have migrated already.
> >
> > Signed-off-by: Marta Rybczynska <[email protected]>
> > ---
> >  meta/classes/cve-check.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/cve-check.bbclass
> b/meta/classes/cve-check.bbclass
> > index 0d7c8a5835..41f2b8304f 100644
> > --- a/meta/classes/cve-check.bbclass
> > +++ b/meta/classes/cve-check.bbclass
> > @@ -61,7 +61,7 @@ CVE_CHECK_REPORT_PATCHED ??= "1"
> >  CVE_CHECK_SHOW_WARNINGS ??= "1"
> >
> >  # Provide text output
> > -CVE_CHECK_FORMAT_TEXT ??= "1"
> > +CVE_CHECK_FORMAT_TEXT ??= "0"
> >
> >  # Provide JSON output
> >  CVE_CHECK_FORMAT_JSON ??= "1"
>
> I'm wondering if we should remove this at this point? I'd prefer the
> build generated machine readable data and then external tools can be
> used to create text based reports of that if/as/where needed rather
> than complicate the code class code with potentially many different
> report formats...
>
> Do we have a tool which can generate a text report from the json?
>
>
I want to remove it :)

But I also adhere to good practices of deprecating first, removing later.

I do have a conversion script, so we can ask people to use it if they want
the old format. The question is if people really still use it.

The removal is a little more complex, because there are some dependencies
between variables. We did it in the yocto-vex-tool code, and it took a
little time.

There will also be a bigger cleanup in the docs when the removal happens...

So, no strong opinion from my side. However, given that the freeze is
really soon,
deprecation looks like a minimum target.

Regards,
Marta
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#203581): 
https://lists.openembedded.org/g/openembedded-core/message/203581
Mute This Topic: https://lists.openembedded.org/mt/108014764/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to