Note that putting patches on GitHub really makes reviews very difficult for everyone. It’s okay to ask ppl to take your patch from there once but if you need to do fix ups and follow-ups you really should fix your email sending.
Alex On Thu 29. Aug 2024 at 22.36, Sven Reschke via lists.openembedded.org < [email protected]> wrote: > On Thu, Aug 29, 2024 at 1:52 AM Richard Purdie via > lists.openembedded.org > <richard.purdie=linuxfoundation.org@...> wrote: > > On Mon, 2024-08-26 at 12:01 -0700, Sven Reschke via > lists.openembedded.org wrote: > > Hi Alex and Alexandre, > > sorry for the delay. > I've created a PR on Github on top of your latest changes: > https://github.com/Nanowires/oe-core-clone/pull/1 > > I did try this on our automated testing and there were some issues: > > musl build failures: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/64/builds/9440/steps/11/logs/stdio > > https://autobuilder.yoctoproject.org/typhoon/#/builders/45/builds/9456/steps/11/logs/stdio > > This can be fixed by using realpath(path, NULL) API instead of > canonicalize_file_name(path), we have done such changes > in few packages e.g. elfutils > > https://sourceware.org/git/?p=elfutils.git > ;a=commitdiff;h=06263dda990be6778a4beb33481cfd39ce60c623;hp=fd0cee63fb02455a5021ca298da8dadb4df63a9a > > there is a meta-oe patch for ssiapi > > https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-support/ssiapi/ssiapi/0003-replace-canonicalize_file_name-with-realpath.patch > > > first of all: Thanks for the automated testing :-) > Yes, I broke the realpath.patch with my update. I've pushed a fix, which > should solve this issue. > > > systemd+sysvinit build failure: > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/72/builds/9431/steps/25/logs/stdio > > Cheers, > > Richard > > For this I fixed the install.patch (which I removed in the first place). > Could you re-run the tests with my latest commits? ;-) > > Best regards, > Sven > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#203947): https://lists.openembedded.org/g/openembedded-core/message/203947 Mute This Topic: https://lists.openembedded.org/mt/107960881/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
