Hi Quentin,

Shall I update the SRCREV to latest and revert below commit change as patch would be fine for kirstone?
https://gitlab.freedesktop.org/mesa/kmscube/-/commit/4961a04b4a434aefbd412eb24fb76998036eaaf6

Or shall I push specific change as a patch instead of updating SRCREV for master, scarthgap and kirkstone? Please suggest.


Thanks,
Purushottam

---------- Original Message ----------

From : "Quentin Schulz" <[email protected]>
To : Purushottam Kumar Sr. Research Engineer(purushottam27.kumar), [email protected]
Date : 2024/09/30 23:30:52 [GMT+09:00]
Subject : Re: [OE-core] [kirkstone][PATCH v3] kmscube: Add patch to fix -int-conversion build error


Hi Purushottam,

On 9/30/24 1:53 PM, Purushottam Choudhary via lists.openembedded.org wrote:
> On some platforms, `EGLNativeDisplayType` is an int instead of
> a pointer, in which case the void pointer will raise
> a `-Wint-conversion`.
> 
> Add change as a patch instead of updating SRCREV .
> if we update SRCREV might will get compatiblity issue
> with current gstreamer 1.20.7 version because SRCREV brings changes
> which resolves negotiation issues encountered with V4L2 stateless
> hardware video decoders when using kmscube video playback option
> which has gstreamer dependency requirement to 1.22.0
> 

@Steve for some context: 
https://gitlab.freedesktop.org/mesa/kmscube/-/commit/4961a04b4a434aefbd412eb24fb76998036eaaf6 
this is the problematic commit not allowing us to bump kmscube further 
than d12ba659695631e7a22dce8fa5d0bc576a9c2241 (or we do, and revert that 
patch instead).

> Signed-off-by: Purushottam Choudhary <[email protected]>

Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#205130): 
https://lists.openembedded.org/g/openembedded-core/message/205130
Mute This Topic: https://lists.openembedded.org/mt/108734161/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to