On Tue, 2024-10-01 at 10:53 +0100, Richard Purdie wrote: > On Fri, 2024-09-27 at 15:20 +0200, Claus Stovgaard via > lists.openembedded.org wrote: > > SDKIMAGE_INSTALL_COMPLEMENTARY_HARD_DEPENDS_ONLY is a new variable > > to > > enable installation of recommended complementary packages in the > > classic > > sdk. Use it to get populate_sdk behave like Kirkstone and earlier. > > > > As installing complementary recommended packages is known to cause > > bugs > > it was disabled. Though it can be usefull when having dummy > > packages > > with DEPENDS to create SDK's. Use this variable with caution. > > > > Signed-off-by: Claus Stovgaard <[email protected]> > > The commit message needs improvement since I can't tell what this > means/does. > > What was the behaviour in kirkstone and how did it change? Why/when > would I need it? > > What is a "hard depends"? > > I don't have an opinion on whether should do something like this or > not > as yet, mainly as I can't tell what it is doing. Can you explain it > without reference to "behaviour in kirkstone"? > > I also have an aversion to "1" as a magic value. Have a look at > bb.utils.to_boolean() for that. >
Thanks for your comments. I will try to improve the commit message, and split the documentation part out from the rest. The issue it tries to solve is the one described here. https://lists.openembedded.org/g/openembedded-core/topic/108100662#msg203745 In short - with this commit https://git.yoctoproject.org/poky/patch/?id=4705dd264681d908f144dd4d9bf1f6175f68d8b9 the behaviour of complementary package handling changed ignore RRECOMMENDS. This was changed to fix some long standing bugs for RDEPENDS from -dev packages. Though as the complementary handling of including packages from RRECOMMENDS is needed in some situations the purpose of this patch is to change from hardcoded disabled to be a configurable option. A prime example for where we need the installation of packages in RRECOMMENDS, and not ignore it is for generating a SDK with all dependencies for an application. E.g. if we have a dummy recipe with packages in DEPENDS, the packages listed in DEPENDS will end in RRECOMMENDS. See process_depchains in package.py for the pkg_adddeprrecs method, and not be installed in the SDK. Using the variable introduced with this patch, will install packages from RRECOMMENDS in the SDK, and we have a classic SDK with all the packages from DEPENDS and ready to be used for the application. Hope it make better sense for you now, and I will try to describe it better in the commit message. Regards Claus > Cheers, > > Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#205280): https://lists.openembedded.org/g/openembedded-core/message/205280 Mute This Topic: https://lists.openembedded.org/mt/108685995/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
