Hi Bruce,
On 15/10/2024 08:21:13+0000, Bruce Ashfield wrote:
> On Tue, Oct 15, 2024 at 6:07 AM Antonin Godard
> <[email protected]> wrote:
> >
> > This variable has been introduced by commit
> > 1d4c120edeb6e45665eafd6962a10ebb89d758eb ("kernel-yocto: allow branch
> > auditing to be suspended") but its usage removed by commit
> > 0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3 ("kernel-yocto: streamline
> > patch, configuration and audit phases").
> >
> > I haven't found any reference to this variable elsewhere... so remove it
> > entirely.
>
> I'm actually working on some code that will once again use that
> variable.
>
> Paul Barker submitted some changes that allow in-tree defconfigs
> to be applied alongside of the fragments that the project hosts. I'm
> enabling auditing of those fragments as part of that integration,
>
> That audit can be a bit noisy, so I'm using that flag to allow it to
> be disabled for some fragments.
>
> Bruce
Ok sounds good. I'm actually working on documenting some of the variables in
kernel-yocto.bbclass, which is why I noticed this.
By the way, it feels like the description of KCONF_AUDIT_LEVEL is a bit off
compared to what's done in the code.
Comment:
# LEVELS:
# 0: no reporting
# 1: report options that are specified, but not in the final config
# 2: report options that are not hardware related, but set by a BSP
KCONF_AUDIT_LEVEL ?= "1"
KCONF_BSP_AUDIT_LEVEL ?= "0"
Code:
if [ ${KCONF_AUDIT_LEVEL} -gt 1 ]; then
bbfatal_log "`cat
${meta_dir}/cfg/merge_config_build.log`"
else
bbfatal_log "Details can be found at:
${S}/${meta_dir}/cfg/merge_config_build.log"
fi
I don't see the link between level 2 and the code here.
Cheers,
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#205916):
https://lists.openembedded.org/g/openembedded-core/message/205916
Mute This Topic: https://lists.openembedded.org/mt/109019408/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
