On Tue, 22 Oct 2024 at 17:57, Ross Burton <[email protected]> wrote:
>
> On 16 Oct 2024, at 20:36, Alexander Kanavin via lists.openembedded.org
> <[email protected]> wrote:
> > diff --git a/meta/recipes-devtools/python/python3/fix-armv5.patch
> > b/meta/recipes-devtools/python/python3/fix-armv5.patch
> > new file mode 100644
>
> Probably worth mentioning this in the commit message.
Done (v2 is coming).
> > diff --git a/meta/recipes-devtools/python/python3/python3-manifest.json
> > b/meta/recipes-devtools/python/python3/python3-manifest.json
> > index 292c5bbc5da..4b7f9cc7e33 100644
> > --- a/meta/recipes-devtools/python/python3/python3-manifest.json
> > +++ b/meta/recipes-devtools/python/python3/python3-manifest.json
> > @@ -103,17 +103,6 @@
> > ],
> > "cached": []
> > },
> > - "2to3": {
> > - "summary": "Python automated Python 2 to 3 code translator",
> > - "rdepends": [
> > - "core"
> > - ],
> > - "files": [
> > - "${bindir}/2to3*",
> > - "${libdir}/python${PYTHON_MAJMIN}/lib2to3"
> > - ],
> > - "cached": []
> > - },
>
> Was 2to3 removed? This isn’t in the commit message.
Also done.
> > "files": [
> > - "${libdir}/python${PYTHON_MAJMIN}/chunk.py",
> > - "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/audioop.*.so",
> > -
> > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/ossaudiodev.*.so",
> > - "${libdir}/python${PYTHON_MAJMIN}/sndhdr.py",
> > - "${libdir}/python${PYTHON_MAJMIN}/sunau.py",
> > "${libdir}/python${PYTHON_MAJMIN}/wave.py"
> > ],
>
> There’s been a lot of deprecation modules that are being removed in this
> release, might be worth listing them.
I've added a link to upstream changelog which lists everything that's
been removed.
> > "crypt": {
> > "summary": "Python basic cryptographic and hashing support",
> > "rdepends": [
> > - "core",
> > - "math",
> > - "stringold"
> > + "core"
> > ],
> > "files": [
> > - "${libdir}/python${PYTHON_MAJMIN}/crypt.py",
> > "${libdir}/python${PYTHON_MAJMIN}/hashlib.py",
> > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_blake2.*.so",
> > - "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_crypt.*.so",
> > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_hashlib.*.so",
> > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_md5.*.so",
> > "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_sha1.*.so",
>
> This explains the buildhistory-diff:
>
> packages/cortexa57-poky-linux/python3/python3-crypt: RDEPENDS: removed
> "libxcrypt (['>= 4.4.36']) python3-math python3-stringold”
>
> Is that package no longer building native code, or is it failing to build
> native code?
crypt has been removed in 3.13, so it's simply not existing to begin with.
> > @@ -909,22 +867,12 @@
> > "summary": "Python Internet Protocol servers",
> > "rdepends": [
> > "core",
> > - "crypt",
> > - "datetime",
> > - "email",
> > - "html",
> > - "io",
> > - "math",
> > - "mime",
> > - "netclient",
> > - "stringold"
> > + "io"
> > ],
>
> That dependency list change seems suspiciously large.
Just below there's a line that removes the cgi module and those are
all dependencies of that.
The remaining socketserver needs only core and io.
> > @@ -1147,7 +1092,6 @@
> > "core"
> > ],
> > "files": [
> > - "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.*.so",
> > "${libdir}/python${PYTHON_MAJMIN}/tkinter"
> > ],
> > "cached": []
>
> I still see a _tkinter.c in the cpython source tree, so this doesn’t seem
> right?
Manifest is supposed to list only things built and installed by
default, and this isn't. Packaging it should be fixed up in the recipe
by those who enable the feature. I'm not sure why tkinter python
module is still installed and what's the difference/relationship
between them. Users, if any, should figure this out.
> > +CACHED_CONFIGUREVARS:append:class-target = " \
> > + ac_cv_libatomic_needed=yes \
>
> Why is this needed?
Added to commit message.
> > + d.setVar('ALLOW_EMPTY:${PN}-fcntl', '1')
>
> Looks like you moved fcntl into core, this should be mentioned. Is this an
> attempt at preserving the name for compatibility? Might be neater to have it
> as a RPROVIDES on -core instead.
fcntl is now mentioned in commit.
There's a similar pre-existing line for pkgutil, so I'd rather do this
as a separate follow-up.
> > + cp ${UNPACKDIR}/python3-manifest.json ${WORKDIR}
> > + cp ${UNPACKDIR}/get_module_deps3.py ${WORKDIR}
>
> Did the manifest updating just not work? Would it be neater to just change
> the script to work in unpackdir instead of copying the files further?
Yes, this broke when UNPACKDIR was introduced. I'd rather do a separate fix-up.
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#206239):
https://lists.openembedded.org/g/openembedded-core/message/206239
Mute This Topic: https://lists.openembedded.org/mt/109050859/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
