LGTM, thanks. Reviewed-by: Joshua Watt <[email protected]>
On Fri, Oct 25, 2024 at 9:25 PM Hongxu Jia <[email protected]> wrote: > > Build gcc and check gcc-14.2.0/README in objset is available > > $ oe-selftest -r spdx.SPDX30Check.test_gcc_include_source > ... > 2024-10-26 01:24:57,063 - oe-selftest - INFO - test_gcc_include_source > (spdx.SPDX30Check.test_gcc_include_source) > 2024-10-26 01:28:24,204 - oe-selftest - INFO - The spdxId of > gcc-14.2.0/README in gcc.spdx.json is > http://spdx.org/spdxdocs/gcc-f2eaeb0d-b54b-53ba-899a-8c36c21139bf/88d5068ffd41e5ea6b4e0dd390b23bf499bb2b6674a41e09eaf2a887eced16c8/sourcefile/42 > 2024-10-26 01:28:26,369 - oe-selftest - INFO - ... ok > 2024-10-26 01:28:33,315 - oe-selftest - INFO - > ---------------------------------------------------------------------- > 2024-10-26 01:28:33,316 - oe-selftest - INFO - Ran 1 test in 216.457s > 2024-10-26 01:28:33,316 - oe-selftest - INFO - OK > 2024-10-26 01:28:45,254 - oe-selftest - INFO - RESULTS: > 2024-10-26 01:28:45,254 - oe-selftest - INFO - RESULTS - > spdx.SPDX30Check.test_gcc_include_source: PASSED (209.31s) > 2024-10-26 01:28:45,260 - oe-selftest - INFO - SUMMARY: > 2024-10-26 01:28:45,260 - oe-selftest - INFO - oe-selftest () - Ran 1 test in > 216.457s > 2024-10-26 01:28:45,260 - oe-selftest - INFO - oe-selftest - OK - All > required tests passed (successes=1, skipped=0, failures=0, errors=0) > > Signed-off-by: Hongxu Jia <[email protected]> > --- > meta/lib/oeqa/selftest/cases/spdx.py | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/meta/lib/oeqa/selftest/cases/spdx.py > b/meta/lib/oeqa/selftest/cases/spdx.py > index be595babb3..8384070219 100644 > --- a/meta/lib/oeqa/selftest/cases/spdx.py > +++ b/meta/lib/oeqa/selftest/cases/spdx.py > @@ -110,6 +110,7 @@ class SPDX3CheckBase(object): > "SDKMACHINE", > "SDK_DEPLOY", > "SPDX_VERSION", > + "SSTATE_PKGARCH", > "TOOLCHAIN_OUTPUTNAME", > ], > target_name, > @@ -136,6 +137,34 @@ class SPDX30Check(SPDX3CheckBase, OESelftestTestCase): > "{DEPLOY_DIR_SPDX}/{MACHINE_ARCH}/packages/base-files.spdx.json", > ) > > + > + def test_gcc_include_source(self): > + import oe.spdx30 > + > + objset = self.check_recipe_spdx( > + "gcc", > + "{DEPLOY_DIR_SPDX}/{SSTATE_PKGARCH}/recipes/gcc.spdx.json", > + extraconf=textwrap.dedent( > + """\ > + SPDX_INCLUDE_SOURCES = "1" > + """ > + ), > + ) > + > + gcc_pv = get_bb_var("PV", "gcc") > + filename = f'gcc-{gcc_pv}/README' > + found = False > + for software_file in objset.foreach_type(oe.spdx30.software_File): > + if software_file.name == filename: > + found = True > + self.logger.info(f"The spdxId of {filename} in gcc.spdx.json > is {software_file.spdxId}") > + break > + > + self.assertTrue( > + found, > + f"Not found source file {filename} in gcc.spdx.json\n" > + ) > + > def test_core_image_minimal(self): > objset = self.check_recipe_spdx( > "core-image-minimal", > -- > 2.25.1 >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#206467): https://lists.openembedded.org/g/openembedded-core/message/206467 Mute This Topic: https://lists.openembedded.org/mt/109220137/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
