On 30 Oct 2024, at 09:38, Mathieu Dubois-Briand <[email protected]> wrote: > > On Tue, Oct 29, 2024 at 04:15:48PM +0000, Ross Burton wrote: >> Instead of using os.popen() directly, and passing a string then having >> to quote the arguments, use subprocess.run() and pass a list of arguments. >> >> Signed-off-by: Ross Burton <[email protected]> >> --- > > Hi Ross, > > It seems this breaks a lot of things on the autobuilder, I get lot of > fails like: > FileNotFoundError: [Errno 2] No such file or directory: > 'x86_64-poky-linux-objdump’
This is fun: the old code silently ignored the case when it was meant to be running objdump on binaries but objdump is not in the sysroot. For example, qemuwrapper has INHIBIT_DEFAULT_DEPS so no binutils, but the packaging code tries to run objcopy on everything executable still. I’ll add more error handling paths. Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#206582): https://lists.openembedded.org/g/openembedded-core/message/206582 Mute This Topic: https://lists.openembedded.org/mt/109280229/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
