> -----Original Message-----
> From: [email protected] 
> <[email protected]> On Behalf Of Richard Purdie
> Sent: den 6 november 2024 11:10
> To: [email protected]
> Subject: [OE-core] [PATCH v2] bitbake.conf: Enable ipv6/acl/xattr for 
> nativesdk
> 
> I was surprised to realise our buildtools doesn't support IPv6 which breaks
> usage in our own autobuilder, let alone anywhere else.
> 
> Enable ipv6 in our SDKs and enable acl/xattr as well before we have the same
> kind of issues with those, these features are now common on most linux systems
> and we should be defaulting to including them.
> 
> Signed-off-by: Richard Purdie <[email protected]>
> ---
> v2 - Handle mingw which doesn't support acl/attr
> 
>  meta/conf/bitbake.conf | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 14e761e2e7e..02bbf0e7a52 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -916,7 +916,8 @@ IMAGE_FEATURES += "${EXTRA_IMAGE_FEATURES}"
>  # Native distro features (will always be used for -native, even if they
>  # are not enabled for target)
>  DISTRO_FEATURES_NATIVE ?= "acl x11 ipv6 xattr"
> -DISTRO_FEATURES_NATIVESDK ?= "x11"
> +DISTRO_FEATURES_NATIVESDK ?= "acl x11 ipv6 xattr"
> +DISTRO_FEATURES_NATIVESDK:mingw32 = "x11 ipv6"

While I know you do not like :remove in OE-Core, isn't this a case where it 
should be used? I.e.:

DISTRO_FEATURES_NATIVESDK:remove:mingw32 = "acl xattr"

Otherwise someone doing DISTRO_FEATURES_NATIVESDK += "foobar" in their 
configuration will get a very unexpected result if they are building for 
mingw32 after the above is integrated.

An alternative would be:

DISTRO_FEATURES_NATIVE_DEFAULT = "acl x11 ipv6 xattr"
DISTRO_FEATURES_NATIVE_DEFAULT:mingw32 = "x11 ipv6"
DISTRO_FEATURES_NATIVE ?= "${DISTRO_FEATURES_NATIVE_DEFAULT}"
DISTRO_FEATURES_NATIVESDK ?= "${DISTRO_FEATURES_NATIVE_DEFAULT}"

>  
>  # Normally target distro features will not be applied to native builds:
>  # Native distro features on this list will use the target feature value

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#206803): 
https://lists.openembedded.org/g/openembedded-core/message/206803
Mute This Topic: https://lists.openembedded.org/mt/109422356/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to