Hi, > -----Original Message----- > From: Peter Kjellerstedt <[email protected]> > Sent: Tuesday, November 26, 2024 6:40 PM > To: Denis OSTERLAND-HEIM <[email protected]>; > [email protected] > Subject: RE: [OE-core] [PATCH 2/3] spdx: add support for WITH operator > > I have some concerns about this change: > * The above change does not really implement support for WITH. It > only supports converting a LICENSE expression containing a > WITH clause (expressed using the "+" operator) from bitbake > format into SPDX format. All the actual handling of WITH clauses > is missing. Right, it is just a first step.
> * There are a lot of complexities related to the incompatible > license handling (which is the main reason for the license > handling in meta/lib/oe/license.py). There will be problems if > someone specifies a LICENSE as "Foo + Exception | Bar". E.g., > consider what should happen if "Foo" is in INCOMPATIBLE_LICENSE. Good point. Would definetly require more logic. > * We also used to use "+" to indicate "or later". This can be seen > in obsolete_license_list(). Weird things will probably happen if > an old LICENSE like "GPL2+ & LGPLv2+" is encountered. Right, as specified by SPDX. [^1] This is really a blocking point for '+'. > > It would probably be easier to just add a GPL-2.0-with-syscall-exception > (as was initially suggested), but containing the full GPL-2.0 license as > well as the exception (compare to, e.g., Apache-2.0-with-LLVM-exception. I agree. > > I also note that out of the six licenses used in OE-Core/OpenEmbedded > that use exceptions: > > Apache-2.0-with-LLVM-exception > GPL-2.0-with-GCC-exception [^2] > GPL-2.0-with-OpenSSL-exception > GPL-3-with-bison-exception [^3] > GPL-3.0-with-GCC-exception [^4] > GPL-3.0-with-autoconf-exception [^5] > > only Apache-2.0-with-LLVM-exception and GPL-2.0-with-OpenSSL-exception > contain the actual license text. The other use an "insert <license> here" > reference. gcc has covered it by using "GPL-3.0-with-GCC-exception & > GPL-3.0-only", but that is not the case for most other recipes. Right. Apache-2.0-with-LLVM-exception and GPL-2.0-with-OpenSSL-exception are not listed on spdx.org/licenses and the others are listed with the "insert <license> here". The clean way would be to implement the WITH operator. To avoid the effort and improve the situation, maybe it would be an idea to copy GPL-2.0-only together with GPL-2.0-with-GCC-exception into GPL-2.0-only-with-GCC-exception. Regards, Denis > > //Peter [^1]: https://spdx.github.io/spdx-spec/v2.3/SPDX-license-expressions/ [^2]: https://spdx.org/licenses/GPL-2.0-with-GCC-exception.html [^3]: https://spdx.org/licenses/GPL-2.0-with-bison-exception.html [^4]: https://spdx.org/licenses/GPL-3.0-with-GCC-exception.html [^5]: https://spdx.org/licenses/GPL-3.0-with-autoconf-exception.html
smime.p7s
Description: S/MIME cryptographic signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#207915): https://lists.openembedded.org/g/openembedded-core/message/207915 Mute This Topic: https://lists.openembedded.org/mt/109769577/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
