On Thu, Dec 19, 2024 at 1:01 AM Alexander Kanavin via lists.openembedded.org <[email protected]> wrote: > > Please do not add new ‘Penfing’ patches. They should be submitted upstream > first or there should be an explanation of what is pending.
Yeah, i did another patch which is also not correct sadly. Perhaps we need to address it differently than simply trying type punning. > > Alex > > On Thu 19. Dec 2024 at 9.42, wangmy via lists.openembedded.org > <[email protected]> wrote: >> >> From: Wang Mingyu <[email protected]> >> >> error with clang: >> file.c:200:8: error: assigning to 'char *' from 'const char *' >> discards qualifiers >> [-Werror,-Wincompatible-pointer-types-discards-qualifiers] >> | 200 | base = pathname; >> | | ^ ~~~~~~~~ >> >> Signed-off-by: Wang Mingyu <[email protected]> >> --- >> .../0001-Fix-const-qualifier-error.patch | 35 +++++++++++++++++++ >> .../nfs-utils/nfs-utils_2.8.2.bb | 1 + >> 2 files changed, 36 insertions(+) >> create mode 100644 >> meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-const-qualifier-error.patch >> >> diff --git >> a/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-const-qualifier-error.patch >> >> b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-const-qualifier-error.patch >> new file mode 100644 >> index 0000000000..8fc327e7aa >> --- /dev/null >> +++ >> b/meta/recipes-connectivity/nfs-utils/nfs-utils/0001-Fix-const-qualifier-error.patch >> @@ -0,0 +1,35 @@ >> +From a21344466e4c315d6d7098920819983f2d15573b Mon Sep 17 00:00:00 2001 >> +From: Wang Mingyu <[email protected]> >> +Date: Thu, 19 Dec 2024 06:18:59 +0000 >> +Subject: [PATCH] Fix const qualifier error >> + >> +Fixes clang error >> +file.c:200:8: error: assigning to 'char *' from 'const char *' >> +discards qualifiers >> +[-Werror,-Wincompatible-pointer-types-discards-qualifiers] >> +| 200 | base = pathname; >> +| | ^ ~~~~~~~~ >> + >> +Upstream-Status: Pending >> + >> +Signed-off-by: Wang Mingyu <[email protected]> >> +--- >> + support/nsm/file.c | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/support/nsm/file.c b/support/nsm/file.c >> +index de122b0..2733210 100644 >> +--- a/support/nsm/file.c >> ++++ b/support/nsm/file.c >> +@@ -197,7 +197,7 @@ nsm_make_temp_pathname(const char *pathname) >> + >> + base = strrchr(pathname, '/'); >> + if (base == NULL) >> +- base = pathname; >> ++ base = (char*)(&pathname); >> + else >> + base++; >> + >> +-- >> +2.43.0 >> + >> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.8.2.bb >> b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.8.2.bb >> index 543c68f7f5..45821b98e8 100644 >> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_2.8.2.bb >> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_2.8.2.bb >> @@ -31,6 +31,7 @@ SRC_URI = >> "${KERNELORG_MIRROR}/linux/utils/nfs-utils/${PV}/nfs-utils-${PV}.tar.x >> >> file://0001-Makefile.am-fix-undefined-function-for-libnsm.a.patch \ >> file://clang-warnings.patch \ >> file://0001-locktest-Makefile.am-Do-not-use-build-flags.patch \ >> + file://0001-Fix-const-qualifier-error.patch \ >> " >> >> SRC_URI[sha256sum] = >> "a39bbea76ac0ab9e6e8699caf3c308b6b310c20d458e8fa8606196d358e7fb15" >> -- >> 2.43.0 >> >> >> >> > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#208927): https://lists.openembedded.org/g/openembedded-core/message/208927 Mute This Topic: https://lists.openembedded.org/mt/110195053/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
