On Thu Dec 26, 2024 at 11:47 AM CET, Marcel Ziswiler wrote:
> Hi Mathieu
>
> On Thu, 2024-12-26 at 10:42 +0100, Mathieu Dubois-Briand wrote:
> >  On Wed Dec 25, 2024 at 11:32 AM CET, Marcel Ziswiler wrote:
> > > Signed-off-by: Marcel Ziswiler <[email protected]>
> > > ---
> > > 
> > 
> > Hi Marcel,
> > 
> > I'm taking this patch in my branch, but just a quick note: it looks like
> > you setup is breaking the patch format while sending it, so picking it
> > is a bit painful. Particularly, it looks like it drops spaces on line
> > ends, which do mess the changes on patches.
>
> V1 indeed had an issue but V2 I sent straight with patman which uses git 
> format-patch and git send-email and
> should not mess with any such.
>
> > Can you fix this for your next patches please ?
>
> I am happy to fix anything but V2 should really apply cleanly, not?

No, I still had the issue. Either using b4 or saving the raw mail, the
patch does not apply. Running:

b4 am -s [email protected]
git am v2_20241225_marcel_gettext_upgrade_0_22_5_0_23.mbx

The git am fails with:

Applying: gettext: upgrade 0.22.5 -> 0.23
error: patch failed: 
meta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patch:1
error: 
meta/recipes-core/gettext/gettext/0001-intl-Fix-build-failure-with-make-j.patch:
 patch does not apply
error: patch failed: 
meta/recipes-core/gettext/gettext/0001-tests-autopoint-3-unset-MAKEFLAGS.patch:16
error: 
meta/recipes-core/gettext/gettext/0001-tests-autopoint-3-unset-MAKEFLAGS.patch: 
patch does not apply
error: patch failed: meta/recipes-core/gettext/gettext/parallel.patch:15
error: meta/recipes-core/gettext/gettext/parallel.patch: patch does not apply
error: patch failed: 
meta/recipes-core/gettext/gettext/serial-tests-config.patch:41
error: meta/recipes-core/gettext/gettext/serial-tests-config.patch: patch does 
not apply
error: patch failed: meta/recipes-core/gettext/gettext/use-pkgconfig.patch:30
error: meta/recipes-core/gettext/gettext/use-pkgconfig.patch: patch does not 
apply
Patch failed at 0001 gettext: upgrade 0.22.5 -> 0.23

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#209090): 
https://lists.openembedded.org/g/openembedded-core/message/209090
Mute This Topic: https://lists.openembedded.org/mt/110282327/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to