On Thu, 2025-01-23 at 08:18 +0000, Richard Purdie via lists.openembedded.org wrote: > Hi Hongxu, > > On Thu, 2025-01-23 at 00:03 -0800, hongxu via lists.openembedded.org wrote: > > > > Convert do_convert_crlf_to_lf from a separate task to a postfunc or > > prefunc > > is not suitable for this case, the postfunc and prefunc is executed > > in > > bb.build.exec_task [1], but do_patch is called by bb.build.exec_func > > in archiver.bbclass and meta/lib/oe/spdx_common.py > > Which means postfunc or prefunc will not be invoked in > > bb.build.exec_func > > > > I think prepend function to task do_patch could workaround the issue, > > v2 incoming > > > > [1] > > https://git.yoctoproject.org/poky/commit/?id=0f516fe9a043276c670622895c4760ff6468f293 > > > That is a good point. It makes me wonder if we shouldn't tweak the code > to allow exec_func to optionally execute the pre/post funcs though. I > still don't like having to manually fix up these things, or start using > append/prepend which the pre/post funcs were meant to avoid.
Of course that still doesn't handle the [depends] flag which is really a task variable. Your patch changing it to DEPENDS won't work unforutnately as that is added to the sysroot too late to function correctly. I guess this is why we've ended up working around the issue. It would be nice to fix this properly somehow but I'm not sure how we can do that now. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#210179): https://lists.openembedded.org/g/openembedded-core/message/210179 Mute This Topic: https://lists.openembedded.org/mt/110748047/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
