On Wed, 2025-02-19 at 10:42 +0100, Sofiane HAMAM via lists.openembedded.org wrote: > Some modules (like Perl's MakeMaker) do not support non ASCII > characters in build folder's path, which leads to task failures. > A sanity check is added to warn the user. > > Fixes [YOCTO #15764] > > Signed-off-by: Sofiane HAMAM <sofiane.ha...@smile.fr> > --- > meta/classes-global/sanity.bbclass | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/meta/classes-global/sanity.bbclass > b/meta/classes-global/sanity.bbclass > index 66693fc9b9..5d33ef9d73 100644 > --- a/meta/classes-global/sanity.bbclass > +++ b/meta/classes-global/sanity.bbclass > @@ -299,6 +299,11 @@ def check_path_length(filepath, pathname, limit): > return "The length of %s is longer than %s, this would cause > unexpected errors, please use a shorter path.\n" % (pathname, limit) > return "" > > +def check_non_ascii(filepath, pathname): > + if(not filepath.isascii()): > + return "Non-ASCII character(s) in %s path (\"%s\") detected. This > would cause unexpected errors, please use a ASCII-only path.\n" % (pathname, > filepath)
Thanks for the patch! I'd rephrase the second sentence to "This would cause build failures as we build software that doesn't support this." I'd also leave a comment in the code against that check which says that it is Perl MakeMaker that has this issue, just so we know in future why we added this. Cheers, Richard
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#211697): https://lists.openembedded.org/g/openembedded-core/message/211697 Mute This Topic: https://lists.openembedded.org/mt/111266915/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
