Hi Dmitry, Alex,

Still wrong commit title, please fix for v5. It's updating from 25.2.8 to 25.3.1.

On 12/15/25 10:46 AM, Alexander Kanavin via lists.openembedded.org wrote:
On Sat, 13 Dec 2025 at 04:12, Dmitry Baryshkov via
lists.openembedded.org
<[email protected]> wrote:
diff --git 
a/meta/recipes-graphics/mesa/files/0001-freedreno-don-t-encode-build-path-into-binaries.patch
 
b/meta/recipes-graphics/mesa/files/0001-freedreno-don-t-encode-build-path-into-binaries.patch
index 136ed8623bcb..6948abe43952 100644
--- 
a/meta/recipes-graphics/mesa/files/0001-freedreno-don-t-encode-build-path-into-binaries.patch
+++ 
b/meta/recipes-graphics/mesa/files/0001-freedreno-don-t-encode-build-path-into-binaries.patch
@@ -84,27 +84,6 @@ index 98e49b8fcf0e..145e72597eb9 100644

   dep_libarchive = dependency('libarchive', allow_fallback: true, required: 
false)
   dep_libxml2 = dependency('libxml-2.0', allow_fallback: true, required: false)
-diff --git a/src/freedreno/registers/gen_header.py 
b/src/freedreno/registers/gen_header.py
---- a/src/freedreno/registers/gen_header.py
-+++ b/src/freedreno/registers/gen_header.py
-@@ -885,13 +885,14 @@ The rules-ng-ng source files this header
- """)
-       maxlen = 0
-       for filepath in p.xml_files:
--              maxlen = max(maxlen, len(filepath))
-+              maxlen = max(maxlen, len(os.path.basename(filepath)))
-       for filepath in p.xml_files:
--              pad = " " * (maxlen - len(filepath))
-+              filename = os.path.basename(filepath)
-+              pad = " " * (maxlen - len(filename))
-               filesize = str(os.path.getsize(filepath))
-               filesize = " " * (7 - len(filesize)) + filesize
-               filetime = time.ctime(os.path.getmtime(filepath))
--              print("- " + filepath + pad + " (" + filesize + " bytes, from " + 
filetime + ")")
-+              print("- " + filename + pad + " (" + filesize + " bytes, from " + 
filetime + ")")
-       if p.copyright_year:
-               current_year = str(datetime.date.today().year)
-               print()

This sort of tweak needs a mention in the commit message. Has the
patched file been removed? Has the issue been addressed? Why is only
one part of the patch removed?


FYI, done as part of 91ff96b51327 ("freedreno/registers: Remove license/etc from generated headers") part of 25.3.0.

Looks good to me otherwise, have yet to test Rocket from a Yocto build.

Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#227715): 
https://lists.openembedded.org/g/openembedded-core/message/227715
Mute This Topic: https://lists.openembedded.org/mt/116758090/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to