On 12/16/25 21:23, Paul Barker wrote:
On Tue, 2025-12-16 at 02:13 +0000, Chen, Qi wrote:
Ping
Randy told me that this one was hold because the :append concern.
I think I've stated the reason clearly.
The function is not changing /etc/passwd and /etc/shadow. It's just checking
them and changing /etc/issues.
Anyway, if anyone has some other approach. Please let me know.
Hi Qi,
We discussed this on the patch review call yesterday.
I understand the reasons for the :append here and the interaction with
the extrausers bbclass. However, this still leaves us with concerns - we
don't want recipes chasing each other using :append as the ordering gets
very difficult to reason about.
The extrausers bbclass also uses :append, would the ordering be correct
if set_user_group and add_empty_root_password_note were both added using
+= instead? If so, let's patch extrausers.bbclass instead of using an
append here.
Hi Paul,
Thanks for the suggestion.
I checked the history. I found that the 'append' in extrausers.bbclass
was first introduced by me. And I cannot recall why I used 'append' at
that time.
After changing to use '+=', things continue to work. And the ordering is
correct.
I'll send out V6.
Regards,
Qi
Best regards,
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#227995):
https://lists.openembedded.org/g/openembedded-core/message/227995
Mute This Topic: https://lists.openembedded.org/mt/116609301/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
