From: Chen Qi <[email protected]>
When toggling ptest for DISTRO_FEATURES, the do_patch function
gets rerun.
The dependency chain is:
do_patch -> do_qa_patch -> DISTRO_FEATURES{ptest}
Such rerun is not necessary. And it's kind of annoying because everything
gets rebuilt, including cross toolchain and recipes not using ptest.
The ERROR_QA and WARN_QA should be enough to trigger the re-run
if unimplemented-ptest is added to one of them. So remove the first
check of DISTRO_FEATURES on ptest to avoid these unnecessary reruns.
Signed-off-by: Chen Qi <[email protected]>
---
meta/classes-global/insane.bbclass | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/meta/classes-global/insane.bbclass
b/meta/classes-global/insane.bbclass
index fed8163c3e..aeffee7983 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1305,9 +1305,7 @@ python do_qa_patch() {
return False
srcdir = d.getVar('S')
- if not bb.utils.contains('DISTRO_FEATURES', 'ptest', True, False, d):
- pass
- elif not (bb.utils.contains('ERROR_QA', 'unimplemented-ptest', True,
False, d) or bb.utils.contains('WARN_QA', 'unimplemented-ptest', True, False,
d)):
+ if not (bb.utils.contains('ERROR_QA', 'unimplemented-ptest', True, False,
d) or bb.utils.contains('WARN_QA', 'unimplemented-ptest', True, False, d)):
pass
elif bb.data.inherits_class('ptest', d):
bb.note("Package %s QA: skipping unimplemented-ptest: ptest
implementation detected" % d.getVar('PN'))
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#228080):
https://lists.openembedded.org/g/openembedded-core/message/228080
Mute This Topic: https://lists.openembedded.org/mt/116837183/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
