Resulttool creates a git tag in the yocto-testresults git and then
copies log files to a newly created folder on the NFS share, whose name
is controlled by the name of this git tag. As tags are unique, the
folder name is also unique, preventing any clash between different
builds.

Today, the tag is pushed after the folder is copied, which can lead to
some issues if for any reason the tag is not pushed. This might also
lead to some race condition. Push the tag before coying data, in order
to prevent these issues.

Fixes [YOCTO #15696]

Signed-off-by: Mathieu Dubois-Briand <[email protected]>
---
 scripts/lib/resulttool/store.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/lib/resulttool/store.py b/scripts/lib/resulttool/store.py
index b143334e699d..da3fac39ea8d 100644
--- a/scripts/lib/resulttool/store.py
+++ b/scripts/lib/resulttool/store.py
@@ -78,11 +78,12 @@ def store(args, logger):
             if args.logfile_archive:
                 excludes = ['*.log', "*.log.zst"]
 
+            push_tag = args.logfile_archive
             tagname = gitarchive.gitarchive(tempdir, args.git_dir, False, 
False,
                                   "Results of {branch}:{commit}", "branch: 
{branch}\ncommit: {commit}", "{branch}",
                                   False, 
"{branch}/{commit_count}-g{commit}/{tag_number}",
                                   'Test run #{tag_number} of 
{branch}:{commit}', '',
-                                  excludes, [], False, keywords, logger)
+                                  excludes, [], push_tag, keywords, logger)
 
             if args.logfile_archive:
                 logdir = args.logfile_archive + "/" + tagname

-- 
2.47.3

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#228689): 
https://lists.openembedded.org/g/openembedded-core/message/228689
Mute This Topic: https://lists.openembedded.org/mt/117000832/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to