Hi Adam,
I'm not seeing the problem with making this optional. A bootimg partition
> requires certain files to be present for a system to boot.
> An extra partition doesn't.
>
My point is, why use the extra-partition plugin without files if omitting
--source already achieves the same result ?
part --source extra-partition --fstype=ext4 --label data --fixed-size
500M
Is equivalent to:
part --fstype=ext4 --label data --fixed-size 500M
If your empty extra partition does not requires files, then there is not
need to use the extra-partition plugin.
This is why I designed the plugin to requires files, or creating
directories as in your patch 6/6. If both are optional, I don't see the
added value of using the extra-partition plugin for this use case.
That said, I'm open to making the plugin more flexible. It could allow no
files or directories, but it should raise a warning or a notice.
Pierre-Loup,
On Wed, Jan 14, 2026 at 10:26 AM Adam Duskett <
[email protected]> wrote:
> Hi Pierre! Thanks for the review!
>
> On Tue, Jan 13, 2026 at 4:13 PM Pierre-loup GOSSE via
> lists.openembedded.org <[email protected]>
> wrote:
>
>> Hi Adam,
>>
>> Thanks for your contribution to the plugin.
>>
>>
>> There are many use cases where a user may need a blank partition of a
>> given
>> size and format with no extra files added. Such as an empty data
>> partition.
>>
>>
>> A blank partition can already be created without the extra-partition
>> plugin.
>>
>> Personally, I use the following example line in my WKS file:
>>
>> part --fstype=ext4 --label data --fixed-size 500M
>>
>> This command creates a blank 500MB partition with an ext4 filesystem.
>>
>> In my opinion, the extra plugin should always requires files, similar to
>> the bootimg partition plugin (on which the extra partition plugin is based).
>>
>>
> I'm not seeing the problem with making this optional. A bootimg partition
> requires certain files to be present for a system to boot.
> An extra partition doesn't.
>
> Adam
>
>> Pierre-Loup,
>>
>>
>>
>>
>>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#229315):
https://lists.openembedded.org/g/openembedded-core/message/229315
Mute This Topic: https://lists.openembedded.org/mt/117243676/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
