On Wed, Feb 4, 2026 at 8:58 AM Richard Purdie <
[email protected]> wrote:

> On Wed, 2026-02-04 at 08:46 -0500, Bruce Ashfield via
> lists.openembedded.org wrote:
> >
> >
> > On Tue, Feb 3, 2026 at 9:09 PM Kai Kang via lists.openembedded.org
> <[email protected]> wrote:
> > > From: Kai Kang <[email protected]>
> > >
> > > Check whether kernel config CONFIG_MODULES set or not before do_compile
> > > and do_install in module.bbclass. If not set, it cannot build and
> > > install external modules.
> > >
> >
> >
> > This isn't the place to do that check.
> >
> > If modules are disabled get modules_do_compile out of the tasks.
>
> Does it make sense to have something including module.bbclass which
> doesn't have CONFIG_MODULES set?
>

Yes, that's what I'm trying to say.

Don't even include it if you can't build modules. That puts
the conditional in a single place, and keeps the code cleaner
in the class.

Bruce



>
> Cheers,
>
> Richard
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#230531): 
https://lists.openembedded.org/g/openembedded-core/message/230531
Mute This Topic: https://lists.openembedded.org/mt/117627823/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to