Hi Ross, Sent a v2 patch addressing this here:
https://lists.openembedded.org/g/openembedded-core/message/230927 I noticed that I have two other unreviewed ptest patches i sent earlier for : libassuan : https://lore.kernel.org/all/[email protected]/ libarchive : https://lore.kernel.org/all/[email protected]/ that contain the same pattern. I will update those as well to remove the conditional checks and send updated versions shortly. Best Regards, Pratik ________________________________________ From: Ross Burton <[email protected]> Sent: Tuesday, February 10, 2026 1:03 PM To: Pratik Farkase Cc: [email protected]; [email protected] Subject: Re: [OE-core][PATCH v1] libsolv: add ptest support Hi Patrik, We merged this, but the scripts seem overly defensive, would you be able to send a follow-on cleanup? See comments below. On 2 Feb 2026, at 22:36, Pratik Farkase via lists.openembedded.org <[email protected]> wrote: > +for t in allowuninstall alternative blacklist choicerules choose cleandeps \ > + cplxdeps distupgrade evrcmp excludefromweak favor focus forcebest \ > + lock lockstep multiversion namespace proof recommendations sat \ > + selection strictrepoprio strongrecommends targeted testcase > weakdeps \ > + whatprovideswithdisabled yumobs; do Can this just be for t in testcases/*? > + if [ -x ./runtestcases.sh ] && [ -d testcases/$t ]; then You know these exist as they were installed, and if they were not then we want the tests to fail. Remove the checks. > +do_install_ptest() { > + install -d ${D}${PTEST_PATH}/tools > + install -d ${D}${PTEST_PATH}/test > + > + if [ -f ${B}/tools/testsolv ]; then > + install -m 0755 ${B}/tools/testsolv ${D}${PTEST_PATH}/tools/ > + fi > + > + if [ -f ${S}/test/runtestcases.sh ]; then > + install -m 0755 ${S}/test/runtestcases.sh ${D}${PTEST_PATH}/test/ > + fi > + > + if [ -d ${S}/test/testcases ]; then > + cp -r ${S}/test/testcases ${D}${PTEST_PATH}/test/ > + fi Why all the checks? If the tests rename or move then we _want_ the recipe to fail so the ptest installation can be updated. Cheers, Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#230929): https://lists.openembedded.org/g/openembedded-core/message/230929 Mute This Topic: https://lists.openembedded.org/mt/117606429/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
