Patch v5 sent here: https://lists.openembedded.org/g/openembedded-core/message/230936
removes conditional checks for both run-ptest and do_install_ptest(). Best Regards, Pratik ________________________________________ From: Pratik Farkase <[email protected]> Sent: Tuesday, February 10, 2026 7:54 PM To: Ross Burton Cc: [email protected]; [email protected] Subject: Re: [OE-core][PATCH v3] libconfig: add ptest support Hi Ross, Thanks for the review. I have removed the conditional checks in do_install_ptest() so the build will fail if the test artifacts are missing, as suggested. Patch v4 is sent here: https://lore.kernel.org/all/[email protected]/ Thanks for your feedback. I will keep this in mind for future implementations. Best Regards, Pratik ________________________________________ From: Ross Burton <[email protected]> Sent: Tuesday, February 10, 2026 1:13 PM To: Pratik Farkase Cc: [email protected]; [email protected] Subject: Re: [OE-core][PATCH v3] libconfig: add ptest support Hi Patrik, > On 4 Feb 2026, at 14:58, Pratik Farkase via lists.openembedded.org > <[email protected]> wrote: > +do_install_ptest() { > + install -d ${D}${PTEST_PATH}/tests > + > + if [ -f ${B}/tests/libconfig_tests ]; then > + ${B}/libtool --mode=install install -m 0755 > ${B}/tests/libconfig_tests ${D}${PTEST_PATH}/tests/libconfig_tests > + fi > + > + if [ -d ${S}/tests/testdata ]; then > + cp -r ${S}/tests/testdata ${D}${PTEST_PATH}/tests/ > + fi > +} Same comments are before: don’t use conditions when installing or running the tests unless there’s a very good reason: we _want_ the build or tests to fail if things change. (this one hasn’t merged, so please send a v4) Thanks, Ross
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#230937): https://lists.openembedded.org/g/openembedded-core/message/230937 Mute This Topic: https://lists.openembedded.org/mt/117635219/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
