On Wed, 18 Feb 2026 at 03:18, Peter Kjellerstedt via lists.openembedded.org <[email protected]> wrote: > This was two years ago, so unfortunately I do not remember the exact > circumstances. I have tried to recreate the problem based on the comment > in the code above, but I have not been able to do it. This may be due to > the version of Git that I am using now, compared to what I had two years > ago. However, I also tried it on my old computer that I used when I made > the change above, and which I believe still has the same version of Git > as it did back then. Unfortunately, I still was not able to reproduce > the problem. :( So either I suck at writing comments describing problems, > or I suck at understanding them later... > > I also tried to figure out what (bad) consequences there would be if a > note is attached to an old commit during the rebase, but I really can't > come up with anything. At worst it would be a little annoying when doing > git log. However, I can't see that it would affect the functionality of > devtool in any way. > > So based on the above, it is probably ok to remove the code that sets > and removes the dummy notes.
Thanks for looking into it, Peter. I have meanwhile made a commit that removes the code, and ran 'oe-selftest -r devtool' with it. There were no failures. So the next step is to do an AUH run: https://autobuilder.yoctoproject.org/valkyrie/#/builders/38/builds/58 and carefully review the resulting upgrade messages/patches for correctness - either there will be a test case for what the dummy notes were aiming to fix, or an additional confirmation that the code is okay to remove, as the problem is either very niche, or non-existent. Let's see what comes out of it. Alex
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#231291): https://lists.openembedded.org/g/openembedded-core/message/231291 Mute This Topic: https://lists.openembedded.org/mt/104439182/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
