On 10/05/12 04:22, Richard Purdie wrote:
On Wed, 2012-05-09 at 17:22 -0700, Joshua Lock wrote:
Create signature files, and the directories which contain them, with
rwx for everyone so that they are easily shared with different users
of the same machine.
Signed-off-by: Joshua Lock<[email protected]>
---
bitbake/lib/bb/siggen.py | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index 8c79b17..bd6d59b 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -201,7 +201,12 @@ class SignatureGeneratorBasic(SignatureGenerator):
for dep in data['runtaskdeps']:
data['runtaskhashes'][dep] = self.taskhash[dep]
- p = pickle.Pickler(file(sigfile, "wb"), -1)
+ # Create file with permissive (0777) read/write for easier sharing
+ f = os.fdopen(os.open(sigfile, os.O_RDWR|os.O_CREAT), "wb")
+ # os.open() and os.fdopen() are affected by the users umask so brute
force
+ # the permissions with a call to chmod
+ os.chmod(sigfile, 0777)
+ p = pickle.Pickler(f, -1)
p.dump(data)
Why not just run the chmod after the original pickle code? Its not as if
you avoid a race this way :/.
Sure, that'd work as well.
Though from the general feedback it feels like this series is moot and
all that we really want is a sanity check.
Cheers,
Joshua
--
Joshua Lock
Yocto Project
Intel Open Source Technology Centre
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
