From: Jose Quaresma <[email protected]> When the PATCHTOOL=git, oe-core creates a git repo for the sources with:
git init git add . git commit The git commit fails blindly due to misconfigured user when git don't have the email proper configured. Although the commit command does not fail because it returns 0, it is not executed and the tree remains with all files staged so the following git commands can fail and fails in some cases. This problem has been particularly observed in some obscure and little-used cases in openembedded-core like patching the linux-firmware which only works using PATCHTOOL=git because it deals with binary files. Signed-off-by: Jose Quaresma <[email protected]> --- meta/lib/oe/patch.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/lib/oe/patch.py b/meta/lib/oe/patch.py index afc42df8a7..abc822f7fb 100644 --- a/meta/lib/oe/patch.py +++ b/meta/lib/oe/patch.py @@ -318,6 +318,8 @@ class GitApplyTree(PatchTree): def _initRepo(self): runcmd("git init".split(), self.dir) + runcmd(("git config user.email %s" % self.commitemail).split(), self.dir) + runcmd(("git config user.name %s" % self.commituser).split(), self.dir) runcmd("git add .".split(), self.dir) runcmd("git commit -a --allow-empty -m bitbake_patching_started".split(), self.dir) -- 2.53.0
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#233042): https://lists.openembedded.org/g/openembedded-core/message/233042 Mute This Topic: https://lists.openembedded.org/mt/118295496/21656 Group Owner: [email protected] Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
