Hi Ross,
Thanks for the review. I've sent a follow-up patch that addresses both
points:
1. Added comments documenting why each of these test is skipped:
- debug/dwarf, debug/elf, debug/pe, debug/plan9obj, internal/xcoff:
require binary testdata files excluded to avoid QA errors
- go/types: extremely slow, exceeds ptest timeout
- net/http: requires network access unavailable in qemu
- runtime: requires cgo rebuild and race detector setup
- testing: circular dependency when testing the test framework
- time: requires writable GOROOT for timezone data
2. Removed bash from RDEPENDS — the script already uses #!/bin/sh and
only POSIX constructs. The bash dependency was unnecessary.
The follow-up patch also fixes several other issues found during review
(broken sub-package skip regex, suppressed test output, missing go in
RDEPENDS, GOROOT mutation at runtime).
Here is the link to it :
https://lists.openembedded.org/g/openembedded-core/message/236540
Best Regards,
Pratik
________________________________________
From: Ross Burton <[email protected]>
Sent: Wednesday, May 6, 2026 7:00 PM
To: Pratik Farkase
Cc: [email protected]; [email protected]
Subject: Re: [OE-core][PATCH v6] go: add ptest support
Hi Pratik,
On 14 Apr 2026, at 11:31, Pratik Farkase via lists.openembedded.org
<[email protected]> wrote:
> +SKIP_PKGS="debug/dwarf debug/elf debug/pe debug/plan9obj go/types
> internal/xcoff net/http runtime testing time"
Can you add a comment explaining why these are being skipped? Without this in
the future we have no idea if they’re tests that fail randomly, tests that fail
under load, tests that used to fail but no longer do, or tests that need more
integration to work in ptest.
> +RDEPENDS:${PN}-ptest += "bash tzdata git packagegroup-core-buildessential"
Do you think it would be feasible to un-bashify the code in Go so that it uses
POSIX sh instead of bash?
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#236548):
https://lists.openembedded.org/g/openembedded-core/message/236548
Mute This Topic: https://lists.openembedded.org/mt/118820314/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
