On 5/9/26 6:59 AM, Changqing Li via lists.openembedded.org wrote:

On 5/8/26 22:53, Quentin Schulz wrote:
CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hi Changqing,

On 5/8/26 4:23 AM, Changqing Li via lists.openembedded.org wrote:
When vulkan is enabled in DISTRO_FEATURES without x11 or wayland,
do_configure will failed with error:
gst-libs/gst/vulkan/meson.build:311:4: ERROR: Problem encountered: No Windowing system found. vulkansink will not work

disable vulkan from PACKAGECONFIG when x11 and wayland is not enabled

Signed-off-by: Changqing Li <[email protected]>
---
  .../gstreamer/gstreamer1.0-plugins-bad_1.28.2.bb             | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- bad_1.28.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0- plugins-bad_1.28.2.bb
index cdf3a20dff..c7f081e25b 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- bad_1.28.2.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins- bad_1.28.2.bb
@@ -21,10 +21,13 @@ DEPENDS += "gstreamer1.0-plugins-base"

  inherit gobject-introspection

+PACKAGECONFIG_VULKAN ?= "${@bb.utils.filter('DISTRO_FEATURES', 'vulkan', d)}"
+
  PACKAGECONFIG ??= " \
      ${GSTREAMER_ORC} \
+    ${@'${PACKAGECONFIG_VULKAN}' if (bb.utils.filter('DISTRO_FEATURES', 'x11 wayland', d) != '') else ''} \       ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
-    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan x11', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'directfb x11', d)} \
      ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
      ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
      bz2 closedcaption curl dash dtls hls openssl sbc smoothstreaming \


Should we really build gstreamer-1.0-plugins-bad without vulkan support
even if DISTRO_FEATURES contains it? Seems odd to me.

If we can fail the build, then we could probably do:

ANY_OF_DISTRO_FEATURES = "${@bb.utils.contains('DISTRO_FEATURES',
'vulkan', 'x11 wayland', '', d)}"

I did like this in the first version, see subject: [gstreamer1.0- plugins-bad: add ANY_OF_DISTRO_FEATURES]

Don't reset the version number when it's for the same feature/fix otherwise it's difficult to keep track of patch history :)

For reference, what Changqing meant to point at was: https://lore.kernel.org/openembedded-core/[email protected]/T/#mf5e87479ea92059c8ade15922b960a57f0471046

Cheers,
Quentin
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#236800): 
https://lists.openembedded.org/g/openembedded-core/message/236800
Mute This Topic: https://lists.openembedded.org/mt/119208574/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to