On 5/12/26 16:21, Alexander Kanavin wrote:
On Tue, 12 May 2026 at 05:26, <[email protected]> wrote:
+STABLE_VERSION_REGEX = "${@get_majmin_version_regex(d)}"
+UPSTREAM_STABLE_RELEASE_REGEX = "${STABLE_VERSION_REGEX}\..+"
I think we can make this even more universal:
UPSTREAM_STABLE_RELEASE_REGEX ?= "${STABLE_VERSION_REGEX}.*"
E.g.
- use ?= so the variable can be overridden with a custom
recipe-specific expression (that still has STABLE_VERSION_REGEX in it)
OK
- do not require that . separates the stable series and stable release
part (this will allow openssh to inherit the class)
If we do not use '.' to separate stable parts and the other parts,
recipe with version such as 1.2.3 will also match 1.21.
The name of this bbclass is about 'point' ('.'), but openssh separates
its stable part with 'p', so maybe it should not inherit this bbclass?
- do not require that the stable release suffix is non-empty (this
will cover e.g. systemd when there are no stable maintenance releases
yet, e.g. if PV is at 261 but 261.1 is not yet out, then 261 will be
reported as latest stable release, which is more accurate than 'no
stable release was found')
How about:
UPSTREAM_STABLE_RELEASE_REGEX ?= "^${STABLE_VERSION_REGEX}(\.[^.]+)*$"
This will match 261 as well as 261.1 but not some other unexpected versions.
The regex starts to get a little complicated though.
What do you think?
Regards,
Qi
Other than that, looks good.
Alex
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#236862):
https://lists.openembedded.org/g/openembedded-core/message/236862
Mute This Topic: https://lists.openembedded.org/mt/119269484/21656
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
